Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 7 Jul 2020 06:51:44 -0400 (EDT)
From:   Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To:     Florian Weimer <fw@deneb.enyo.de>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        paulmck <paulmck@linux.ibm.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Paul Turner <pjt@google.com>,
        linux-api <linux-api@vger.kernel.org>,
        Dmitry Vyukov <dvyukov@google.com>,
        Neel Natu <neelnatu@google.com>,
        stable <stable@vger.kernel.org>
Message-ID: <1513249086.945.1594119104750.JavaMail.zimbra@efficios.com>
In-Reply-To: <87blkrzssa.fsf@mid.deneb.enyo.de>
References: <20200706204913.20347-1-mathieu.desnoyers@efficios.com> <20200706204913.20347-2-mathieu.desnoyers@efficios.com> <87blkrzssa.fsf@mid.deneb.enyo.de>
Subject: Re: [RFC PATCH for 5.8 1/4] sched: Fix unreliable rseq cpu_id for
 new tasks
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Thread-Topic: sched: Fix unreliable rseq cpu_id for new tasks
Thread-Index: +EFr9o+gVaPjCkmbkUIMJ25jGoinrQ==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

----- On Jul 7, 2020, at 3:30 AM, Florian Weimer fw@deneb.enyo.de wrote:

> * Mathieu Desnoyers:
> 
>> While integrating rseq into glibc and replacing glibc's sched_getcpu
>> implementation with rseq, glibc's tests discovered an issue with
>> incorrect __rseq_abi.cpu_id field value right after the first time
>> a newly created process issues sched_setaffinity.
>>
>> For the records, it triggers after building glibc and running tests, and
>> then issuing:
>>
>>   for x in {1..2000} ; do posix/tst-affinity-static  & done
>>
>> and shows up as:
>>
>> error: Unexpected CPU 2, expected 0
>> error: Unexpected CPU 2, expected 0
>> error: Unexpected CPU 2, expected 0
>> error: Unexpected CPU 2, expected 0
>> error: Unexpected CPU 138, expected 0
>> error: Unexpected CPU 138, expected 0
>> error: Unexpected CPU 138, expected 0
>> error: Unexpected CPU 138, expected 0
> 
> As far as I can tell, the glibc reproducer no longer shows the issue
> with this patch applied.
> 
> Tested-By: Florian Weimer <fweimer@redhat.com>

Thanks a lot Florian for your thorough review and testing !

Mathieu


-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com