Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp967162ybt; Tue, 7 Jul 2020 04:48:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz4SjRcTN3LsoWFQPNxi3fA9rKJW7zoZc1oSVauaHRRUKMnoQJEzAXVqFODVj28iiVspM1g X-Received: by 2002:aa7:c54f:: with SMTP id s15mr63004036edr.175.1594122507884; Tue, 07 Jul 2020 04:48:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594122507; cv=none; d=google.com; s=arc-20160816; b=cKw3rExaQuXWmgdpHz6vyKKumYTPMiEPxgclfWL2/qKCEu7VySEgDauIZCMQ1DeDiQ LIJsmgNIwUrBiLMe5tIRjKX5tLy9d4+COzb3GWBN7aBofB12mA8FbMh3WsTqs8fMLE1u atY8kq/PuCJMsLs3qIV69/yi6AFxNSKh2J5uzCznZTNj7YruRcCEsZ3FHoOwSU0ZOpP7 rBNIXN45xgXQAB1vvQzBlIZntchojFhNd9I1hPZcvUA4ezsfD83s0dqqYvkbSlDvtk/R p1dgazy4dLHu7Da16SLY01mDL8O5Sj/8oIwLq4LtL7go2Cf8sN7+6xjyRM1lw7NMgLR+ eQhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=v0igr9QwaaqhDp8mCiBLQ9iONluqSM4GoTQMRgXkM64=; b=giaD5ytzyjiV9nBNTGtEi3GLT5SWTcWvM8sR94Yc6DsQJUSxtR60FnrfvCE81SLBz6 TDi09jFo2LjCwKVRADdE6YHVBDaI1ubb5enjc5Vel0xNO0job3qa8Rmkif3pDjA/GGTj tsuHtqdlBEfcZG+DaBNWVhPlhNHQanYnub5qwfy+PZG2cDnkJ67HP3xUvpETCkXOwNiK 1Xhrt6WvgidorUJBIHDIw+ZJtQ3ZDsDo2JWT3+wswAFl5yX3N8mmgcqJLrbs9l6qs6Qd QI+UpZqtLkfcelQCZE8kCJN6vsSsKxtZmLVgIsH/7XgjJ5vNQw4x9xa+xSSbAK2p0g8k 3d9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w11si16324847edq.29.2020.07.07.04.48.04; Tue, 07 Jul 2020 04:48:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728701AbgGGLrh (ORCPT + 99 others); Tue, 7 Jul 2020 07:47:37 -0400 Received: from out4436.biz.mail.alibaba.com ([47.88.44.36]:37560 "EHLO out4436.biz.mail.alibaba.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728410AbgGGLre (ORCPT ); Tue, 7 Jul 2020 07:47:34 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R401e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e07488;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=19;SR=0;TI=SMTPD_---0U20joWQ_1594122436; Received: from alexshi-test.localdomain(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0U20joWQ_1594122436) by smtp.aliyun-inc.com(127.0.0.1); Tue, 07 Jul 2020 19:47:20 +0800 From: Alex Shi To: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com Cc: Alex Shi , Michal Hocko , Vladimir Davydov Subject: [PATCH v15 08/21] mm/memcg: add debug checking in lock_page_memcg Date: Tue, 7 Jul 2020 19:46:40 +0800 Message-Id: <1594122412-28057-9-git-send-email-alex.shi@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1594122412-28057-1-git-send-email-alex.shi@linux.alibaba.com> References: <1594122412-28057-1-git-send-email-alex.shi@linux.alibaba.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a debug checking in lock_page_memcg, then we could get alarm if anything wrong here. Suggested-by: Johannes Weiner Signed-off-by: Alex Shi Cc: Johannes Weiner Cc: Michal Hocko Cc: Vladimir Davydov Cc: Andrew Morton Cc: cgroups@vger.kernel.org Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org --- mm/memcontrol.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 19622328e4b5..fde47272b13c 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -1983,6 +1983,12 @@ struct mem_cgroup *lock_page_memcg(struct page *page) if (unlikely(!memcg)) return NULL; +#ifdef CONFIG_PROVE_LOCKING + local_irq_save(flags); + might_lock(&memcg->move_lock); + local_irq_restore(flags); +#endif + if (atomic_read(&memcg->moving_account) <= 0) return memcg; -- 1.8.3.1