Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200625191708.4014533-1-lee.jones@linaro.org> <20200625191708.4014533-5-lee.jones@linaro.org>
In-Reply-To: <20200625191708.4014533-5-lee.jones@linaro.org>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Tue, 7 Jul 2020 14:41:25 +0200
Message-ID: <CACRpkda4tphGY1UvMtR6k1vDNaKpsgyQLcVLQL9h964pDz=O3g@mail.gmail.com>
Subject: Re: [RESEND 04/10] regulator: dbx500-prcmu: Remove unused function dbx500_regulator_testcase()
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jun 25, 2020 at 9:17 PM Lee Jones <lee.jones@linaro.org> wrote:

> There isn't any code present within the current kernel to
> override this 'weak' function.  Besides returning '0', which
> is never checked anyway, the whole function appears to be
> superfluous.
>
> Consequently fixes W=3D1 warning:
>
>  drivers/regulator/dbx500-prcmu.c:113:27: warning: no previous prototype =
for =E2=80=98dbx500_regulator_testcase=E2=80=99 [-Wmissing-prototypes]
>  113 | int __attribute__((weak)) dbx500_regulator_testcase(
>  | ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij