Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1020063ybt; Tue, 7 Jul 2020 06:05:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjLRAHwno7stRH96k9WPzXZ+l0QyfV5lOa13WZux7Ahm5G0kTiGAeHl/4Agbccx42K0ac2 X-Received: by 2002:a17:907:94cf:: with SMTP id dn15mr51092227ejc.457.1594127110944; Tue, 07 Jul 2020 06:05:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594127110; cv=none; d=google.com; s=arc-20160816; b=AoX5ocTyVIkYedWh4Bh12+2t9TQEmyT7/T9WGvzTcHmcSw9Pr9d0djcZWlF9qCfIDO 1yavem4/anSoi1AnNwb1KcaVTNIPoEv4lQNAZlQZHHtgfhhF03gyQ3z7rQrzBlKp3Nt0 vDUlJ24C24beVNePFDs1Q5idD7sASb7uYgCavFFzea7CFJtMlyIGaEYJyHw4T/Emb3HT bX2nQV9fyahynX0V+K6m72GV9kTaVaUAeYVPV7m2Of1aVbYBCVWp93MBiRFr7gql7Nph 4X8W7oH4yxyPIZpLupyy7GxUV/yvxQJRpc/mKEoU363WtLlQDiEBJraVrQWlmwOUaVOB HliA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=ASfn/SdgsMD8Cz7XZocX1lE3LU6oMKH6msyO6ek58eE=; b=HOttDr+0Aj4l/UH5QUO1wpRO8Xgt6KEct+qn9FC/GaDwV3pdlQatTxr2Yjlb/6PEQ0 uSV8XmVj6SH0w4lsWKVSb0o3cQS4Z6f7Q2ULoXcy4dFf1NxufDOoI7sqSun5oiIWUjhd l7QQmzXfbslB28Fx5xrN5FsMudvm8zgfJPqAb1K5N9NiEVMV+EljqrXYpQO5XmtX1V0p B/FL9wFYfF5gWlCJKG8XbP026JQAfq3WSDDvNReIg2YFdTv2Ckx9nz5fwfGDcXuyuGP9 YuUn6MbvgUuCuWmXP9ubG6M+nXuiPaj1iyFloQ3Auv0OM/Bw/SLt95CHz8UrbmFOnYq/ gHTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b="GO/4rq7g"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l24si14570737ejp.69.2020.07.07.06.04.46; Tue, 07 Jul 2020 06:05:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b="GO/4rq7g"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726911AbgGGNEU (ORCPT + 99 others); Tue, 7 Jul 2020 09:04:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725944AbgGGNEU (ORCPT ); Tue, 7 Jul 2020 09:04:20 -0400 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2785C061755 for ; Tue, 7 Jul 2020 06:04:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ASfn/SdgsMD8Cz7XZocX1lE3LU6oMKH6msyO6ek58eE=; b=GO/4rq7gAyyDRI481Ajgw2gkQ5 X/UYcVN3Cy1yH2ng88FsPgNR9DWJuhBH/VT5GeNfTAhJUuQcLcZhhm/L+0/lCJgxeLmzimvYDNtkE 8zD3B4X1w08cm0wka/Kkml33BIfILK+QHKmq3QitG0KvC40j4Nqb/J/Ms2i2i28RjKwUP0s/4SEcV wLhIV6JoutJdcW/HoE4kHNa9DIn3z9kLu4UJZKohoKSn1ky9JTFf3qBy42ItEgvUEmR63hQP9r3tq yA1CRWiysaVbAKs9fiJ/La0zEXUnGPqfstfxfUMhB7BDg95Hro9ZBpqGC2uk+Nq61E1mn8AJo8Upv NP+nOTcQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsnGf-0000Aj-Oy; Tue, 07 Jul 2020 13:04:13 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id CD0793013E5; Tue, 7 Jul 2020 15:04:10 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 83E07213C912B; Tue, 7 Jul 2020 15:04:10 +0200 (CEST) Date: Tue, 7 Jul 2020 15:04:10 +0200 From: Peter Zijlstra To: "Ahmed S. Darwish" Cc: Ingo Molnar , Will Deacon , Thomas Gleixner , "Paul E. McKenney" , "Sebastian A. Siewior" , Steven Rostedt , LKML Subject: Re: [PATCH v3 06/20] seqlock: Extend seqcount API with associated locks Message-ID: <20200707130410.GO4800@hirez.programming.kicks-ass.net> References: <20200630054452.3675847-1-a.darwish@linutronix.de> <20200630054452.3675847-7-a.darwish@linutronix.de> <20200706212148.GE5523@worktop.programming.kicks-ass.net> <20200707084024.GA4097637@debian-buster-darwi.lab.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200707084024.GA4097637@debian-buster-darwi.lab.linutronix.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 07, 2020 at 10:40:24AM +0200, Ahmed S. Darwish wrote: > On Mon, Jul 06, 2020 at 11:21:48PM +0200, Peter Zijlstra wrote: > > On Tue, Jun 30, 2020 at 07:44:38AM +0200, Ahmed S. Darwish wrote: > > > +#include > > > > Why? why not include those lines directly here? Having it in a separate > > file actually makes it harder to read. > > > > The seqlock_types_internal.h file contains mostly a heavy sequence of > typeof() branching macros, which is not related to the core logic of > sequence counters or sequential locks: > IMHO it makes sense to isolate these "not core logic" parts. Adding all > of this to plain seqlock.h makes it almost unreadable. So I applied it all yesterday and tried to make sense of the resulting indirections and couldn't find stuff -- because it was hidding in another file. Specifically I disliked that *seqcount_t* naming and didn't see how it all connected. And that other file is less than 200 lines, which resulted in me wondering why it needed to be hidden away like that. Anyway, let me muck around with that a bit.