Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200701211044.18590-1-r-rivera-matos@ti.com> <20200701211044.18590-3-r-rivera-matos@ti.com>
 <20200702205320.GA1672139@bogus> <54914eed-4a65-745b-b61b-9515737023e3@ti.com>
In-Reply-To: <54914eed-4a65-745b-b61b-9515737023e3@ti.com>
From:   Rob Herring <robh@kernel.org>
Date:   Tue, 7 Jul 2020 08:40:20 -0600
Message-ID: <CAL_JsqKXC1TFFCq6HBqdbHNeWbA=SnCqHkTx+FQXiPYDLb6sNw@mail.gmail.com>
Subject: Re: [EXTERNAL] Re: [PATCH v15 2/4] dt-bindings: power: Convert
 battery.txt to battery.yaml
To:     Ricardo Rivera-Matos <r-rivera-matos@ti.com>
Cc:     =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali@kernel.org>,
        "open list:THERMAL" <linux-pm@vger.kernel.org>,
        Sandeep Patil <sspatil@android.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Andrew F. Davis" <afd@ti.com>, Dan Murphy <dmurphy@ti.com>,
        Sebastian Reichel <sre@kernel.org>, devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 6, 2020 at 12:45 PM Ricardo Rivera-Matos
<r-rivera-matos@ti.com> wrote:
>
> Rob
>
> On 7/2/20 3:53 PM, Rob Herring wrote:
> > On Wed, 01 Jul 2020 16:10:42 -0500, Ricardo Rivera-Matos wrote:
> >> From: Dan Murphy <dmurphy@ti.com>
> >>
> >> Convert the battery.txt file to yaml and fix up the examples.
> >>
> >> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> >> ---
> >>   .../bindings/power/supply/battery.txt         |  86 +---------
> >>   .../bindings/power/supply/battery.yaml        | 157 ++++++++++++++++++
> >>   2 files changed, 158 insertions(+), 85 deletions(-)
> >>   create mode 100644 Documentation/devicetree/bindings/power/supply/battery.yaml
> >>
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.6/dist-packages/dtschema/schema/types.yaml'
> > Documentation/devicetree/bindings/Makefile:20: recipe for target 'Documentation/devicetree/bindings/power/supply/battery.example.dts' failed
> > make[1]: *** [Documentation/devicetree/bindings/power/supply/battery.example.dts] Error 255
> > make[1]: *** Waiting for unfinished jobs....
> > Makefile:1347: recipe for target 'dt_binding_check' failed
> > make: *** [dt_binding_check] Error 2
> I think your bot is looking for the types.yaml in the wrong place.

Really? Yet it works fine on thousands of other patches?

> '/usr/local/lib/python3.6/dist-packages/dtschema/schema/types.yaml'
> should be
> '/usr/local/lib/python3.6/dist-packages/dtschema/schemas/types.yaml'. I
> renamed might 'schemas' directory to 'schema' and my battery.yaml passed
> the dt_binding_check.

Maybe fix the 'schema/' path in your schema file which is wrong.

Rob