Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1130497ybt; Tue, 7 Jul 2020 08:26:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJydYUFKvjwu80O2NIdBN5BTMEpMBUIbEUS6Y4A1JQaA9xSoqhWyLc2jCosyZGNwPwgQ2YUc X-Received: by 2002:a17:906:c201:: with SMTP id d1mr41220370ejz.40.1594135568707; Tue, 07 Jul 2020 08:26:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594135568; cv=none; d=google.com; s=arc-20160816; b=W3iN2qQX9fHiwDx+DgSSy+Ybp2r19m5HlqqoGKyxV6TCtXPTKZ2wIieAYU7kAxlNTx n/lHGoTwRlRgSvU+p0sEv5JQ+u+iogrKMEJUM8Bnl/i32306ZsL8xdIw7KnrnCTLQ1H6 KCN8m6efhUyHu6OaRTN766i3ASDZ5rBC5Lg7z9SWsm2Dw8Kk+6YvPIgzVrlUEzdgfLjn ckh/846AYtaNRsxEj4djrzXgtItivY/Kp8u5gaItH9tS2xGRT3kk4NihqROUVdqBD02Q KI6guFwnjLLkklrjyZBydVjlP1OVSI1FedjYswimM/h/bK86k+PTkH3Rkry0gVBq1b+y gsYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=5sey6mUAbvrqLJAy97noUijTqGsfj8mZWKi6siPlwJ0=; b=W8ZPnn7E1r+lb3Sb0i/fuhMVylBrynzPIFNjrBJrIhH9y1DJDZov93biBfCWlWaYTM iqL1RjaZ8tTtcYBGobIEV+kpINSx5Cr6ATupYf1hCDmBfb13AqhkMdUAFSZDh/9WKQW1 RWVXcYSaQKUQuxigqpBxeE+OfCiODFYJskS8TP6MPJJrYyu6asArOhxH33KCQsom48v8 WDMJQy5xIDXpDkWXF/+Ez0riCl5UAWNOLRaEou0W18oGwRnrPnXelmUwGzvxR1cVu9AY GR3e7lnwOOG5v0Qthsz87ORNjKYTDmzVvwOMWnD+N2xmHKeLLIhXtLcmInV02fa8CPhC 69Ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ILhvWnPg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g16si14213570edu.513.2020.07.07.08.25.45; Tue, 07 Jul 2020 08:26:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ILhvWnPg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729857AbgGGPW3 (ORCPT + 99 others); Tue, 7 Jul 2020 11:22:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:34822 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729837AbgGGPWU (ORCPT ); Tue, 7 Jul 2020 11:22:20 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 256A720773; Tue, 7 Jul 2020 15:22:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594135339; bh=SZMo4lJ02JixxSULEiH5qQ2oMHm5bYU/eZWP5P/FmwY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ILhvWnPgGb5okctaSjC27CeuY0KrpA2Q+zFzi8t7nyKQmP7sqReNCOXERZvykZ6hq gQwPuvXm/fQQSwoFfJUmQDXnJDpU0gQAfajk5YWDuiLww5+rb64nVpDoH4Kwhnd51I ZjTUMuX0kRp+xIjDdQ/Dt9JZSccZxY3pHKC7fBso= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "J. Bruce Fields" , Sasha Levin Subject: [PATCH 5.4 37/65] nfsd: fix nfsdfs inode reference count leak Date: Tue, 7 Jul 2020 17:17:16 +0200 Message-Id: <20200707145754.265692996@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200707145752.417212219@linuxfoundation.org> References: <20200707145752.417212219@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: J. Bruce Fields [ Upstream commit bf2654017e0268cc83dc88d56f0e67ff4406631d ] I don't understand this code well, but I'm seeing a warning about a still-referenced inode on unmount, and every other similar filesystem does a dput() here. Fixes: e8a79fb14f6b ("nfsd: add nfsd/clients directory") Signed-off-by: J. Bruce Fields Signed-off-by: Sasha Levin --- fs/nfsd/nfsctl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c index 596ed6a42022d..be418fccc9d86 100644 --- a/fs/nfsd/nfsctl.c +++ b/fs/nfsd/nfsctl.c @@ -1335,6 +1335,7 @@ void nfsd_client_rmdir(struct dentry *dentry) WARN_ON_ONCE(ret); fsnotify_rmdir(dir, dentry); d_delete(dentry); + dput(dentry); inode_unlock(dir); } -- 2.25.1