Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1130932ybt; Tue, 7 Jul 2020 08:26:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJweuwM8EwquJ5tTrA/yWhRuDVmf0Ihcj8NCpyXtqxCV2Ls047EChwJbN3+5gtMNjaRrsrJF X-Received: by 2002:a17:906:c943:: with SMTP id fw3mr47000855ejb.55.1594135601917; Tue, 07 Jul 2020 08:26:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594135601; cv=none; d=google.com; s=arc-20160816; b=0gSV+/2zYjVORvfHh1UjUPS+y0yTQK+55Jy5BtorUm55BTn0dT4U2RiM6Mb1onkl3J O7My3hCRAafOulrcjFMsakbziQ8meYA49UdwMxQtvMIp0/ncaYp2/Ux1wKJ6sa/VijaU Xym6QOT/7Ftt0NsHsXMqzWTtaqeNPxiVk8zq0RfC9hp4vek5HRRgT/YuTbqpFzFlaIOQ n4SQeKxpA6yf2aR+tzAu27HQtQKCZdf4g4bUxHOBmW1mYik64OdyhZOSyRXeWzyiTKMW ob5Ixj2IHui3/GuyNJqfJJFhrgK/bdYdOtPCTGQUbtU3i/zgOQfnZ1IPYmXf9e070DmD ffdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=qEXaeO/RBCE4gxY1zUzUaGeK5kTxbPVf9w68DVQb/Ww=; b=Dn7M165lELe9br9GHQ8vCZ6gygSrFf8NljkGd1dhu4z0fQerRnCwDe2+pLX5V5xOZO c0f8dnYVd89IdvnvQ+cbCOxJpzC33xta1GLJniKkGsUp21UDOYrksLmXlcbqbd6vHFG6 Js6/9F8py0QBd9DUSh3Yx9dcjPVxffyNfjKcjzqHmLNA4+xnI3ltToqmD7pXYZa2jtCM 3myLvdfPEDC8PigbP1H36z4tH2zJ8F79HGeyNzBUJBZuDa1ZJtZziytYC4JoBI3aiGMp GPFSYLBbmV4zqxMYcMBuh7n8g0pC8fs8sSZHlu0iclPmwn8xWq2jZDV7OlkGEC4w+RQy LrIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ww75triT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dp8si20397338ejc.281.2020.07.07.08.26.18; Tue, 07 Jul 2020 08:26:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ww75triT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728440AbgGGPXM (ORCPT + 99 others); Tue, 7 Jul 2020 11:23:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:36096 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729950AbgGGPXK (ORCPT ); Tue, 7 Jul 2020 11:23:10 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DE16B207CD; Tue, 7 Jul 2020 15:23:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594135389; bh=t48+Xhwq9/p8QGgsPqjcI4Z6WeMmsCy0ku+QepkjvXw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ww75triTQgAHN1JQZlS7oCve4Mw5O51C7dvlpVr34Cy2g1e0gJN2sao9ZSksI8DoD 2VbSIjz/RSjrPBHVwDk2p5bLpScrUl7ps/AYlbXEuRRbPu196ssG35gfWU6wIpRNIo X3LeD7/obuIAIA7Z0UKORme9v4x7h5YUAw9ElNFo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tero Kristo , Santosh Shilimkar , Tony Lindgren , Sasha Levin Subject: [PATCH 5.7 021/112] soc: ti: omap-prm: use atomic iopoll instead of sleeping one Date: Tue, 7 Jul 2020 17:16:26 +0200 Message-Id: <20200707145801.997136149@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200707145800.925304888@linuxfoundation.org> References: <20200707145800.925304888@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tero Kristo [ Upstream commit 98ece19f247159a51003796ede7112fef2df5d7f ] The reset handling APIs for omap-prm can be invoked PM runtime which runs in atomic context. For this to work properly, switch to atomic iopoll version instead of the current which can sleep. Otherwise, this throws a "BUG: scheduling while atomic" warning. Issue is seen rather easily when CONFIG_PREEMPT is enabled. Signed-off-by: Tero Kristo Acked-by: Santosh Shilimkar Signed-off-by: Tony Lindgren Signed-off-by: Sasha Levin --- drivers/soc/ti/omap_prm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/soc/ti/omap_prm.c b/drivers/soc/ti/omap_prm.c index 96c6f777519c0..c9b3f9ebf0bbf 100644 --- a/drivers/soc/ti/omap_prm.c +++ b/drivers/soc/ti/omap_prm.c @@ -256,10 +256,10 @@ static int omap_reset_deassert(struct reset_controller_dev *rcdev, goto exit; /* wait for the status to be set */ - ret = readl_relaxed_poll_timeout(reset->prm->base + - reset->prm->data->rstst, - v, v & BIT(st_bit), 1, - OMAP_RESET_MAX_WAIT); + ret = readl_relaxed_poll_timeout_atomic(reset->prm->base + + reset->prm->data->rstst, + v, v & BIT(st_bit), 1, + OMAP_RESET_MAX_WAIT); if (ret) pr_err("%s: timedout waiting for %s:%lu\n", __func__, reset->prm->data->name, id); -- 2.25.1