Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1131121ybt; Tue, 7 Jul 2020 08:26:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxAjGPhtdE5Dh1uy0qxwk2/IJroSHhA3NMqx/k3AdVMQAZG4LcGJjiZz6DdShC/4tGDciDv X-Received: by 2002:a17:906:3850:: with SMTP id w16mr48293022ejc.205.1594135617890; Tue, 07 Jul 2020 08:26:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594135617; cv=none; d=google.com; s=arc-20160816; b=y9Bt7gvqsYrVhZ5y5+ecsL8ddpRZfrnAtH0DZAedMGRncieO/RTcGycXpFxDwp8A10 AvO27wCQPG5uk4XAnLQbDEoNWadJzrqim21bLMhum5ILQplaApr+mhQLG0HTy8TAN3fU KwP03Rr5fuc2xdMP3fu7AYJxMZnRxdjO9dKqKPaiJlTsEE3nXtbmzpBLMUb84CRZlLmu t51WGLVRnSeTcIWzwor01p3kqiEXO6V9rIqTIYhUOGH0F9SHUoEPca2lQFNLlz3VIhRk Cu8QIgC8BDKvGyGLwJU/jFpkwaXQpT1qPuEGGoRRAVKvhRtYm6pidzNztJ59RRx5dCNq euQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Txn8U0/mhK1Z0leduZRPbGJ3nLwshlT3O+r63gHOVpE=; b=L6GLNRivsKAJfI6vZjgOYnViEzXPOfMKwP4ASa8xsonOmDOe5R20nahxOKf0ptJnN5 qRzKFs4KJ5EDTxT894DgYkbLCchVTZXVGb2rUnDoJHjUYO/JCLjyMMIa+ojr2oISoeX5 A9HDjnuaTd/+ozIaKjDXJ83ak9HJEJbig2bXW8scKbNJwzbdwwegRvuYzhNdDlQNn3Ze Co7c0zf3eQzWr4JMSs5NivXkm0dDK9osP7ylhFrhbNSYIjIYJEDUcfGetZcBc1ZiE+R5 I+8UaBMYNuC39y2eivIANhGWHwbWNlyPHTLjTslc8TbyS9VjuzXLpkhdXOLHj4Rb5i5y /Baw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oIXdiFjU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o5si18123894edj.37.2020.07.07.08.26.34; Tue, 07 Jul 2020 08:26:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oIXdiFjU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729971AbgGGPXW (ORCPT + 99 others); Tue, 7 Jul 2020 11:23:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:36194 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729954AbgGGPXP (ORCPT ); Tue, 7 Jul 2020 11:23:15 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2DFB52065D; Tue, 7 Jul 2020 15:23:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594135394; bh=fBu0ClO0KQXec2oBjKGmKPAybI4/hbfUxR6w24vd01g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oIXdiFjUTjDIkYxdP1rFuAcrXIqygCZ4l3B0/LLxWa5oA8UAkE1dLb+gSNwX4S62M cfDv0pw2vhmJhjJl7o3Tyo3umTqvVYHPHR+6i0mieV3+bQX6b4wP/ohkODuWaG8LFv XNc2FxRLdlk/LJeeJoXwr25oKLQvicSrNRpQ8JKc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hyunchul Lee , Sungjong Seo , Namjae Jeon , Sasha Levin Subject: [PATCH 5.7 003/112] exfat: call sync_filesystem for read-only remount Date: Tue, 7 Jul 2020 17:16:08 +0200 Message-Id: <20200707145801.096068829@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200707145800.925304888@linuxfoundation.org> References: <20200707145800.925304888@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hyunchul Lee [ Upstream commit a0271a15cf2cf907ea5b0f2ba611123f1b7935ec ] We need to commit dirty metadata and pages to disk before remounting exfat as read-only. This fixes a failure in xfstests generic/452 generic/452 does the following: cp something / mount -o remount,ro the /something is corrupted. because while exfat is remounted as read-only, exfat doesn't have a chance to commit metadata and vfs invalidates page caches in a block device. Signed-off-by: Hyunchul Lee Acked-by: Sungjong Seo Signed-off-by: Namjae Jeon Signed-off-by: Sasha Levin --- fs/exfat/super.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/fs/exfat/super.c b/fs/exfat/super.c index c1b1ed306a485..e879801533980 100644 --- a/fs/exfat/super.c +++ b/fs/exfat/super.c @@ -637,10 +637,20 @@ static void exfat_free(struct fs_context *fc) } } +static int exfat_reconfigure(struct fs_context *fc) +{ + fc->sb_flags |= SB_NODIRATIME; + + /* volume flag will be updated in exfat_sync_fs */ + sync_filesystem(fc->root->d_sb); + return 0; +} + static const struct fs_context_operations exfat_context_ops = { .parse_param = exfat_parse_param, .get_tree = exfat_get_tree, .free = exfat_free, + .reconfigure = exfat_reconfigure, }; static int exfat_init_fs_context(struct fs_context *fc) -- 2.25.1