Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1131135ybt; Tue, 7 Jul 2020 08:26:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyROaptJgZXvz5NV88sVoAu8MYDpl0TsUCX6zmrtujqcwlrUxKpea5W4nRO8VbMKHlEaK3W X-Received: by 2002:a05:6402:2c2:: with SMTP id b2mr61759827edx.184.1594135618737; Tue, 07 Jul 2020 08:26:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594135618; cv=none; d=google.com; s=arc-20160816; b=tDPBudhpq3Ks3KEGh7JARkBZoobT5k7pOECfDbhMV7CtJZcfSrXkYL4ovaetv1woww F9WcmCYCc0KnBMZELGRCzt9BOQCr+yKXalVKKC2he2nGTIx/qvcChs9nL6ucbUDLvB6m 662KncigKvfOEGT0d4YtPgjfMgYu1SJz8G7MBj7R08XUhi3BFOGTJSwDAPVKH0QCktaT ua9VEy4HKbSCiSWxn2o18czmknhJmVQObjeSf3m0f1+EVttcOmzcXD32NiE3gq9z38C1 3MJU5FeIw0HmQ91LNoVcvpg+P1siAkcgQeXbF21yBmEoZUr+FC9CnPpfT4K+fmAfnM3p BOkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=mElQ4J2gtCyXdLsr16sfp5QUbeaOt088zNGJS0IBdOQ=; b=R6dqcEBi7ee9QonOXSqwuagnD9+XkFPM4N0QzOrDCnZ0/jLGo5eurs4/gfU0+T3vc3 aUgBpyqSvfJQuu/PdcI/M3RaM0+Zy9WYYSD3yWJsR+LwZ3lSqVWOrI4EDYATxV3eqKv8 890TNitTOEDD1znkorbVMWodg4AjtAGtQEM2ihKA4hBJ21nN6Yg6HKAaJKJUUxLpu8l+ WUwARUBfblkSeC80B3OM6U+rJC3uxSHO7s5kZyHOgXtUZn1R/fTwgJJJ5FklrObZrQX6 KyGCVIZyl3nwAuNPmYTe3oR0jZWe598ZcAHZRbROwHbAFEWeHiENCQPLaGKdv7vNEQzj YLpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PKs01yrN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rk8si15477260ejb.578.2020.07.07.08.26.35; Tue, 07 Jul 2020 08:26:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PKs01yrN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730204AbgGGPZ2 (ORCPT + 99 others); Tue, 7 Jul 2020 11:25:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:39436 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730194AbgGGPZZ (ORCPT ); Tue, 7 Jul 2020 11:25:25 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 92BEC2065D; Tue, 7 Jul 2020 15:25:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594135525; bh=LYtkAmNPwTE3I2L0i3DtyAATiDsVjeos3MXb8NnbuBI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PKs01yrNpUs+3mO73YKMmtUg4lHHScCl1ZBbN2/IkYk3tkWhLlkuRx9C7ikLhv1GA Py9xJ2escGbQA5gnUDtBOgRCCNBwTyIBeTkP//jEOKUaQswfxbD+FgAGNnEOf6IVQ1 Kx1lvZHOALmUMpudsqntL25HoE3+fNUGkhzS0oe4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hou Tao , Stefano Garzarella , Ming Lei , Jens Axboe , Sasha Levin Subject: [PATCH 5.7 075/112] virtio-blk: free vblk-vqs in error path of virtblk_probe() Date: Tue, 7 Jul 2020 17:17:20 +0200 Message-Id: <20200707145804.566974539@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200707145800.925304888@linuxfoundation.org> References: <20200707145800.925304888@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hou Tao [ Upstream commit e7eea44eefbdd5f0345a0a8b80a3ca1c21030d06 ] Else there will be memory leak if alloc_disk() fails. Fixes: 6a27b656fc02 ("block: virtio-blk: support multi virt queues per virtio-blk device") Signed-off-by: Hou Tao Reviewed-by: Stefano Garzarella Reviewed-by: Ming Lei Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/block/virtio_blk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 9d21bf0f155ee..980df853ee497 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c @@ -878,6 +878,7 @@ static int virtblk_probe(struct virtio_device *vdev) put_disk(vblk->disk); out_free_vq: vdev->config->del_vqs(vdev); + kfree(vblk->vqs); out_free_vblk: kfree(vblk); out_free_index: -- 2.25.1