Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1135777ybt; Tue, 7 Jul 2020 08:32:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzvAtc72W1C92M7LDzo0F/zM7o98OxJlnkbZM+XEZAXkbf9GqHMedtYodMEf7Qci3myYXuR X-Received: by 2002:aa7:c98d:: with SMTP id c13mr52924799edt.188.1594135945195; Tue, 07 Jul 2020 08:32:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594135945; cv=none; d=google.com; s=arc-20160816; b=qdcCLMuaei4z7bVNo6+UeFGwrD8fSFUrEc4+vrXMNNmVCH2moVQIDEDMc7lCssk+4E znQ4gXz5L+/0VS3TL/DwlrWEpRvW+HErkQU9ye3hf1sD0RBEM1xEraabDsoAENrrZe3C hnvZQNFGSje3ysz5JFhDE2LYGE9Oelq++e7lo7e2OMtBESVBMWDe3ekDdlEGYeVHLdwJ tElRpZPF2j0yKUDr3+4UIcuAddqRTS7yscug46tz+O5wRqQ+N09et3ryKm8Htx1RE1dI xTdygkaYiPNzAhQv9tMrr/dboTVFVgSBEej+P846LeQX2f3Ly3V6ybokjMC7ko1ouSYN 9WDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=kaK8QdDGgsTmVphYVs2gYh/nCa8yXGboZ+LWAm+X2O8=; b=Ua30lyf8WGTWoJq5Wed/VGuD75v9FfrgqGpH0Cm9JSIF7ED1OqkfzAR9gNJnxN5jsP ndQcZKy5gyquEbdEG3dNafL1IZvFTyH/fjnsQpeZNLFVz3rpmRn4zyejoHznTO4kiNOZ M02sv8Fo14RNFCbbwj6sdsQN7XHtnX7HKSRhbjEqQmvIizqM9Rq+r6An3yTO5V0LZ6bS f2FJj2krHS0Dl9nI6W1tb0g12wuHya0Uy2NQ/zW6I5Rmnxg6oTgdHI56LjW1/xHfD8QY P4D67HPAeQOybXD2RFo0ZrJk1Po3xiEpVbTJK5fRos6KV0t+RE84Ok0vV378QVlgBAWR XsTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=reFaLGLB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p16si14814917ejj.708.2020.07.07.08.31.55; Tue, 07 Jul 2020 08:32:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=reFaLGLB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730375AbgGGPbw (ORCPT + 99 others); Tue, 7 Jul 2020 11:31:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:35290 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729894AbgGGPWk (ORCPT ); Tue, 7 Jul 2020 11:22:40 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B32F72065D; Tue, 7 Jul 2020 15:22:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594135360; bh=hLB3XyH93zncgHdZnGjMXbexFAUNLhyNMxZ4vKjDV6I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=reFaLGLBUyS1K0jA0Qt8llhrBI/qcSA59cre0bcADEA7YsMvo7u28PeoE5xDczU3+ idhOzcca1iYlsoYI9qofENciSF2QcshW4uxP0Z1BARApACn+f8BIhdryao28DN71RK IakqnBzdr5LB1dsbHvEJImkSbGDqscPLy5rbkQVc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stylon Wang , Nicholas Kazlauskas , Rodrigo Siqueira , Alex Deucher , Sasha Levin Subject: [PATCH 5.7 010/112] drm/amd/display: Fix ineffective setting of max bpc property Date: Tue, 7 Jul 2020 17:16:15 +0200 Message-Id: <20200707145801.487144078@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200707145800.925304888@linuxfoundation.org> References: <20200707145800.925304888@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stylon Wang [ Upstream commit fa7041d9d2fc7401cece43f305eb5b87b7017fc4 ] [Why] Regression was introduced where setting max bpc property has no effect on the atomic check and final commit. It has the same effect as max bpc being stuck at 8. [How] Correctly propagate max bpc with the new connector state. Signed-off-by: Stylon Wang Reviewed-by: Nicholas Kazlauskas Acked-by: Rodrigo Siqueira Signed-off-by: Alex Deucher Cc: stable@vger.kernel.org Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index b7e161f2a47d4..69b1f61928eff 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -4808,7 +4808,8 @@ create_validate_stream_for_sink(struct amdgpu_dm_connector *aconnector, struct drm_connector *connector = &aconnector->base; struct amdgpu_device *adev = connector->dev->dev_private; struct dc_stream_state *stream; - int requested_bpc = connector->state ? connector->state->max_requested_bpc : 8; + const struct drm_connector_state *drm_state = dm_state ? &dm_state->base : NULL; + int requested_bpc = drm_state ? drm_state->max_requested_bpc : 8; enum dc_status dc_result = DC_OK; do { -- 2.25.1