Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932118AbWEAOAQ (ORCPT ); Mon, 1 May 2006 10:00:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932120AbWEAOAP (ORCPT ); Mon, 1 May 2006 10:00:15 -0400 Received: from linux01.gwdg.de ([134.76.13.21]:42212 "EHLO linux01.gwdg.de") by vger.kernel.org with ESMTP id S932118AbWEAOAO (ORCPT ); Mon, 1 May 2006 10:00:14 -0400 Date: Mon, 1 May 2006 16:00:09 +0200 (MEST) From: Jan Engelhardt To: "Randy.Dunlap" cc: lkml , akpm Subject: Re: [PATCH] CodingStyle: add typedefs chapter In-Reply-To: <20060430174426.a21b4614.rdunlap@xenotime.net> Message-ID: References: <20060430174426.a21b4614.rdunlap@xenotime.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 753 Lines: 27 >- Chapter 5: Functions >+ Chapter 5: Typedefs >+ >+Please don't use things like "vps_t". >+It's a _mistake_ to use typedef for structures and pointers. When you see a >+ vps_t a; >+in the source, what does it mean? >+In contrast, if it says >+ struct virtual_container *a; >+you can actually tell what "a" is. >+ >+Lots of people think that typedefs "help readability". Not so. They are >+useful only for: [...] What about task_t vs struct task_struct? Both are used in the kernel. Jan Engelhardt -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/