Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932105AbWEAOVA (ORCPT ); Mon, 1 May 2006 10:21:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932106AbWEAOVA (ORCPT ); Mon, 1 May 2006 10:21:00 -0400 Received: from nproxy.gmail.com ([64.233.182.185]:6680 "EHLO nproxy.gmail.com") by vger.kernel.org with ESMTP id S932105AbWEAOU7 (ORCPT ); Mon, 1 May 2006 10:20:59 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:date:from:to:cc:subject:message-id:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=JCcWDGzvwECyjigltLtTMmCos2ryAwpUF1naGb3++SOraq3f8/CrnyRUkrUmItmgAosVro+kMJUyt9eT8gwiMSVA2VxnGKkLTQ1xfkTftYtWBO8rmnlLwlJKLPUOZY9ccTowAu98bplZmjYHE3kGUT3e185J66LdqUUWfRAi758= Date: Mon, 1 May 2006 18:19:01 +0400 From: Alexey Dobriyan To: Jan Engelhardt Cc: "Randy.Dunlap" , linux-kernel@vger.kernel.org, akpm@osdl.org Subject: Re: [PATCH] CodingStyle: add typedefs chapter Message-ID: <20060501141901.GA7267@mipter.zuzino.mipt.ru> References: <20060430174426.a21b4614.rdunlap@xenotime.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 850 Lines: 25 On Mon, May 01, 2006 at 04:00:09PM +0200, Jan Engelhardt wrote: > >+Please don't use things like "vps_t". > >+It's a _mistake_ to use typedef for structures and pointers. When you see a > >+ vps_t a; > >+in the source, what does it mean? > >+In contrast, if it says > >+ struct virtual_container *a; > >+you can actually tell what "a" is. > >+ > >+Lots of people think that typedefs "help readability". Not so. They are > >+useful only for: > [...] > > What about task_t vs struct task_struct? Both are used in the kernel. task_t => struct task struct task_struct => struct task Roughly 2765 hits :-\ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/