Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1282834ybt; Tue, 7 Jul 2020 11:47:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxC5//t2hzS5XD+Ef+vo5sNqnbRPCB12d5eOzu1ThHk7IY8UlecrQwfEnXoATpmNEzoSNHy X-Received: by 2002:a05:6402:1c8f:: with SMTP id cy15mr63289420edb.308.1594147643203; Tue, 07 Jul 2020 11:47:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594147643; cv=none; d=google.com; s=arc-20160816; b=ZJqXHjOwL084TlTTPaUdrW7B+mkOhKGs2XCoN+2sDvx2kxJpymu7K3E3XrrtS1XkGg +daw1dJhAUeE3ev9x9x22Bn5e5G2B+j0/OEgfJ6OLzEV76sG14kj/ZEWCd0qwZ1+bIIe BmASD2JSGBcHrLre/qaV15xMGqnxCKcST0thk7MmBoI5zT8UXziBrrStX2iJqGCXazcY TzKWWLaInrCkS73soirayewDD/gTtpzvSkOLXRpm1mf999l1ppDvfdEJyTO/7XhBMtUc +9Pd4CYe6jwpLzZRxFUNZczZYm7mTFCsPZrmOtusyjBSPLN/MCmoWV4wPXKljw5kMTfD z3/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=quRkH3piDVa59+VlMcisxCHSXNWjK1kUY5S/yF3xCpA=; b=rp8UeIBe8R6JsmOdSVzu693ussCuNGiTr1uoVXx3LI407Ex7FSOEeX2GEsxy0XEa2M dUEfc2iIfH3PVyAeZt223GBJWqJ+7MBfSWKzmLE4GmZabqKsdXfEWymd3OLNpo1Aatm1 8SMu3jGYfOTPlqbzCgWAXCBFpJDPeY7i/RQ3J86dyAer+iZVUJn7utgwG3Gq3FrJYp7J LHBeTa3q7qZiTGHIW0fTNxpkwi1wZvKu8ldgJpFnRENqh2cGrKXBlo2zLyQ6+KB9BrUC Bg4bw6KVndaJibmh5+Lxw6TwncpEdcOj9Y+EgGf/3Yt8UXJ/6PCQEaEJXe4sQFj+j5e4 d43g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ZRAbnoYe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g7si14730985ejr.748.2020.07.07.11.46.59; Tue, 07 Jul 2020 11:47:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ZRAbnoYe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728590AbgGGSoQ (ORCPT + 99 others); Tue, 7 Jul 2020 14:44:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728191AbgGGSoQ (ORCPT ); Tue, 7 Jul 2020 14:44:16 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3D28C061755 for ; Tue, 7 Jul 2020 11:44:15 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id z13so46322361wrw.5 for ; Tue, 07 Jul 2020 11:44:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=quRkH3piDVa59+VlMcisxCHSXNWjK1kUY5S/yF3xCpA=; b=ZRAbnoYeouFM1/H/tYHdc9ipGYXv4euR+tMeEcMnO6WGF+gx2vOHZ4Tr2eFazJkkEd 60O4ahEF6Nj58WW0Cz/gPtEuDUawAmWRgAMaG1Cf0x7Ne+IyOSwGIFVz/Dsbq7Pk8OMJ kGCTxQvmAj6NBIe7P5YI8MNpEf34m1t7jt74o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=quRkH3piDVa59+VlMcisxCHSXNWjK1kUY5S/yF3xCpA=; b=YjUbIBIHL/eHgujVW50+ChrntCbbz2kcEdLPpeh4uw8/Cx9LcgiCYcGHUTcHUjHh3T iEPWvLWWrwStDYEGB6KzTLqOEqtcdZjBsukq6kODHkhpjF2PVdFVI5hRhm5XZly8L4+F Tz/wULqxWSQPZdr9TSGVKYonnpfVXzCHx20ndXYikz6Ld3rvbK1MbsY2efU2C9/hPVTo L2Rw2U8MAUdJouUgeCIvtdR00y9u1/La4WshZYnlIoO11tzMpSQLE0HFReDYNoDMsW3h woRjkErWJre8WXeCorqHa82G1WhFotl+KfFsN7OWj3mLonjBX/f5/iq+QBME3qXtJVA+ ycJw== X-Gm-Message-State: AOAM5315xC1+TZQcV3712BRG0Pwsh4yWAr4IkYGCqg0T8WmOixLKNnjJ RZeRM80slR0l5e49lRy6bP/l4w== X-Received: by 2002:adf:8444:: with SMTP id 62mr52648218wrf.278.1594147454606; Tue, 07 Jul 2020 11:44:14 -0700 (PDT) Received: from chromium.org (205.215.190.35.bc.googleusercontent.com. [35.190.215.205]) by smtp.gmail.com with ESMTPSA id u186sm2173926wmu.10.2020.07.07.11.44.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 11:44:14 -0700 (PDT) Date: Tue, 7 Jul 2020 18:44:12 +0000 From: Tomasz Figa To: Jonathan Bakker Cc: kyungmin.park@samsung.com, s.nawrocki@samsung.com, mchehab@kernel.org, kgene@kernel.org, krzk@kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/11] media: exynos4-is: Prevent duplicate call to media_pipeline_stop Message-ID: <20200707184412.GJ2621465@chromium.org> References: <20200426022650.10355-1-xc-racer2@live.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jonathan, On Sat, Apr 25, 2020 at 07:26:49PM -0700, Jonathan Bakker wrote: > media_pipeline_stop can be called from both release and streamoff, > so make sure they're both protected under the streaming flag and > not just one of them. First of all, thanks for the patch. Shouldn't it be that release calls streamoff, so that only streamoff is supposed to have the call to media_pipeline_stop()? Best regards, Tomasz