Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 07 Jul 2020 12:56:24 -0700 (PDT)
Message-Id: <20200707.125624.2030141794702878802.davem@davemloft.net>
To:     alobakin@marvell.com
Cc:     kai.heng.feng@canonical.com, anthony.wong@canonical.com,
        irusskikh@marvell.com, kuba@kernel.org, ndanilov@marvell.com,
        mstarovoitov@marvell.com, dmitry.bezrukov@marvell.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: atlantic: Add support for firmware v4
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200707084657.205-1-alobakin@marvell.com>
References: <20200707063830.15645-1-kai.heng.feng@canonical.com>
        <20200707084657.205-1-alobakin@marvell.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Alexander Lobakin <alobakin@marvell.com>
Date: Tue, 7 Jul 2020 11:46:57 +0300

> From:   Kai-Heng Feng <kai.heng.feng@canonical.com>
> Date:   Tue,  7 Jul 2020 14:38:28 +0800
> 
>> We have a new ethernet card that is supported by the atlantic driver:
>> 01:00.0 Ethernet controller [0200]: Aquantia Corp. AQC107 NBase-T/IEEE 802.3bz Ethernet Controller [AQtion] [1d6a:07b1] (rev 02)
>> 
>> But the driver failed to probe the device:
>> kernel: atlantic: Bad FW version detected: 400001e
>> kernel: atlantic: probe of 0000:01:00.0 failed with error -95
>> 
>> As a pure guesswork, simply adding the firmware version to the driver
> 
> Please don't send "pure guessworks" to net-fixes tree. You should have
> reported this as a bug to LKML and/or atlantic team, so we could issue
> it.

Production hardware is shipping to customers and the driver
maintainers didn't add support for this ID yet?  What is that
"atlantic team" waiting for?

Honestly I don't blame someone for posting a patch like this to get it
to work.