Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CAFXsbZrVZjiyO_G6z6T82t0xT36Zi2gGo0kPnt6n58R-rO3TVg@mail.gmail.com>
 <7f627cb8-2eae-cdc9-09fc-e3e612b5632a@gmail.com>
In-Reply-To: <7f627cb8-2eae-cdc9-09fc-e3e612b5632a@gmail.com>
From:   Chris Healy <cphealy@gmail.com>
Date:   Tue, 7 Jul 2020 15:12:25 -0700
Message-ID: <CAFXsbZpq9iY4E+TfMduipfeUr8cUZd4-EVO=+7b3WuOS5fF3cQ@mail.gmail.com>
Subject: Re: [PATCH] ARM64: dts: update MDIO speed and preamble for zii-ultra device
To:     Florian Fainelli <f.fainelli@gmail.com>
Cc:     Shawn Guo <shawnguo@kernel.org>,
        Fabio Estevam <festevam@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>, Rob Herring <robh+dt@kernel.org>,
        devicetree@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux ARM <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jul 7, 2020 at 2:59 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> Hi Chris,
>
> On 7/4/2020 6:26 PM, Chris Healy wrote:
> > Update MDIO configuration with zii-ultra device to fully utilize
> > MDIO endpoint capabilities.  Device supports 12.5MHz clock and
> > doesn't require MDIO preamble.
> >
> > Signed-off-by: Chris Healy <cphealy@gmail.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > index 6a55165bd76a..98aa67a4c040 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > @@ -132,6 +132,8 @@
> >          #address-cells = <1>;
> >          #size-cells = <0>;
> >          status = "okay";
> > +        suppress-preamble = <1>;
>
> suppress-preamble is defined as a boolean, so you can remove the "= <1>"
> part entirely.

Good point, I'll make the necessary change.

> --
> Florian