Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 7 Jul 2020 17:17:08 -0500
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc:     Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] pci: enforce usage of 'pci_channel_state_t'
Message-ID: <20200707221708.GA390968@bjorn-Precision-5520>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200702162651.49526-1-luc.vanoostenryck@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jul 02, 2020 at 06:26:48PM +0200, Luc Van Oostenryck wrote:
> The definition of pci_channel_io_normal and friends is relatively
> complicated and ugly:
> 	typedef unsigned int __bitwise pci_channel_state_t;
> 	enum pci_channel_state {
> 		pci_channel_io_normal = (__force pci_channel_state_t) 1,
> 		...
> 	};
> 
> This is clearly motivated by a desire to have some strong typing
> for this constants but:
> * in C enums are weakly typed (they're essentially the same as 'int')
> * sparse only allow to define bitwise ints, not bitwise enums.
> 
> This series is a preparation step to introduce bitwise enums.
> This would allow to define these constant without having to use
> the force cast:
> 	enum __bitwise pci_channel_state {
> 		pci_channel_io_normal = 1,
> 		...
> 	};
> or, equivalently:
> 	typedef enum __bitwise {
> 		pci_channel_io_normal = 1,
> 		...
> 	} pci_channel_state_t;
> 
> 
> Note: the first patch is, I think, uncontroversial, the other ones
>       less so but can be safely dropped.
> 
> 
> Changes since v1:
> * add missing conversion
> * try to avoid using 'enum pci_channel_state' in include/linux/pci.h
> * try to avoid using 'enum pci_channel_state' in the documentation
> 
> 
> Luc Van Oostenryck (3):
>   pci: use 'pci_channel_state_t' instead of 'enum pci_channel_state'
>   pci: use anonymous 'enum' instead of 'enum pci_channel_state'
>   pci: update to doc to use 'pci_channel_state_t'
> 
>  Documentation/PCI/pci-error-recovery.rst    | 8 ++++----
>  arch/powerpc/kernel/eeh_driver.c            | 2 +-
>  drivers/block/rsxx/core.c                   | 2 +-
>  drivers/dma/ioat/init.c                     | 2 +-
>  drivers/media/pci/ngene/ngene-cards.c       | 2 +-
>  drivers/misc/genwqe/card_base.c             | 2 +-
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-
>  drivers/net/ethernet/intel/ice/ice_main.c   | 2 +-
>  drivers/net/ethernet/intel/ixgb/ixgb_main.c | 4 ++--
>  drivers/net/ethernet/sfc/efx.c              | 2 +-
>  drivers/net/ethernet/sfc/falcon/efx.c       | 2 +-
>  drivers/pci/pci.h                           | 2 +-
>  drivers/pci/pcie/err.c                      | 4 ++--
>  drivers/pci/pcie/portdrv_pci.c              | 2 +-
>  drivers/scsi/aacraid/linit.c                | 2 +-
>  drivers/scsi/sym53c8xx_2/sym_glue.c         | 2 +-
>  drivers/staging/qlge/qlge_main.c            | 2 +-
>  include/linux/pci.h                         | 4 ++--
>  18 files changed, 24 insertions(+), 24 deletions(-)

Since it's all basically "use pci_channel_state_t instead of enum
pci_channel_state", I squashed these all together and applied the
result to pci/error for v5.8, thanks!