Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp53452ybt; Tue, 7 Jul 2020 15:52:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxASkxPcKMYPA8W6NVpq4q9oH3V/gvURwPcaL4WzeOSiWXG6rRZmzDeT3vZAQifp8YsjE1H X-Received: by 2002:a50:cd1a:: with SMTP id z26mr65923032edi.120.1594162338295; Tue, 07 Jul 2020 15:52:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594162338; cv=none; d=google.com; s=arc-20160816; b=SMMJPcXTIRGDQhQiwua/rvIpaGfyMilJP21xwx3Cll7QVNnkoIVywusL8S7MTNZky5 J+U+3Ulc5V7yY3O9FE7vjRQhdwvu6CWVFb4VWmKCuZJ2cRdFUYxdzHmXO2u8BsNBCGkL D6R666FgehmJvIZAqAONUXFWmSyJNYl9vpunVg82U/Am9kfavnV8exabXiuCJpUfIOgq TVKM2kTJdIVqaFKLYARsyuHiJl9zqGNYEgdUD67AWGslvNUaxdCVcyOMccYCLsr8c0dt izyv2sTm5CRxAl/ueiCIiiU0Kmo+thC0QM8wQP1lmhjbYHyLsbPcxD9GRzp2Ikov7UMp Q8kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=P0EsbXrfSbzIz+YsLtD5WOPGA6flbP3qm3T+2XAtLEU=; b=O4lh+kkOXgEoShHf28QKtgjLSOicMhaOwyKqWeXQII85Mkqk0DuvWQoa6gtwRpm5mR 3+uMYQxr/DOx6EqnsHtiuRJv7ZvjDk1NUh/mEsP5djNhHKfDhX3feKxW4GAaQ6cI/IEG N8mmeOmvI93LwY9Lk/W05ZWVOACvpwWHJfmBiT81S5uvhuene/trXiy/80rkOXJSBOoK qUHFu8BV1lBx41KiO6wP72MlQRuaAKT47JudJsSze5BE7GiSQc9tRCunwyiHFV3ITGIc 86m0KQuHuGfcpcvGCqzI25+4sMtaa1Qt0mjVoVQr36R3QEjD7LgdfWRVSfnAnik8uMJn Fgag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id by12si15536034edb.99.2020.07.07.15.51.55; Tue, 07 Jul 2020 15:52:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728607AbgGGWjG convert rfc822-to-8bit (ORCPT + 99 others); Tue, 7 Jul 2020 18:39:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726951AbgGGWjG (ORCPT ); Tue, 7 Jul 2020 18:39:06 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2DA4C061755; Tue, 7 Jul 2020 15:39:05 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 3BD85120ED48D; Tue, 7 Jul 2020 15:39:05 -0700 (PDT) Date: Tue, 07 Jul 2020 15:39:04 -0700 (PDT) Message-Id: <20200707.153904.491848475455000428.davem@davemloft.net> To: linus.luessing@c0d3.blue Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com, martin@linuxlounge.net, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2] bridge: mcast: Fix MLD2 Report IPv6 payload length check From: David Miller In-Reply-To: <20200705191017.10546-1-linus.luessing@c0d3.blue> References: <20200705191017.10546-1-linus.luessing@c0d3.blue> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 07 Jul 2020 15:39:05 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Linus L?ssing Date: Sun, 5 Jul 2020 21:10:17 +0200 > Commit e57f61858b7c ("net: bridge: mcast: fix stale nsrcs pointer in > igmp3/mld2 report handling") introduced a bug in the IPv6 header payload > length check which would potentially lead to rejecting a valid MLD2 Report: > > The check needs to take into account the 2 bytes for the "Number of > Sources" field in the "Multicast Address Record" before reading it. > And not the size of a pointer to this field. > > Fixes: e57f61858b7c ("net: bridge: mcast: fix stale nsrcs pointer in igmp3/mld2 report handling") > Acked-by: Nikolay Aleksandrov > Signed-off-by: Linus L?ssing Applied and queued up for -stable, thank you.