Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp195723ybt; Tue, 7 Jul 2020 20:18:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz3NDZgk75J9wd+M0NENzEwjLCEoMcE6cIKex91yIvzjSHMBgaPd5oFEwJkogsFfFuaHDzs X-Received: by 2002:a17:906:fcb1:: with SMTP id qw17mr48564288ejb.445.1594178314312; Tue, 07 Jul 2020 20:18:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594178314; cv=none; d=google.com; s=arc-20160816; b=j7ew2GpfXlc6z9a4I8e3TQZzhEbnXcUTZKP7on+MxU/h56eIq+Od+1GiDdR3NuKqYM 30evfSo2XKYJZmx/6J8k31KgLmZLlynrmSwlMPESFZo5JH/5IHUPQ3Smzw2Utu26yQ6D mDBGyhecoDcHUbLkJcaSy7SimY6hZ4BNF28tlTCMp/cxufmVwymnFALyADpJk8oeP2IC JTylAOmNMdWxZzNOlVYgXYSf9axhxQmdiTl2R4EqmZTIdYJpfEaFB8gPTzwJnp3NoDbZ b9I6shya62nz0u4F5B2nJgHVeo4tP+qq1rvdyewp9ZB8Tlz/L0d3R3ZeOj5eD7N4yoRv UFxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=oAwKqHK24P/HMH2S8nsQQ/C5A8edfnTk57osWeiH3rQ=; b=m4Ap7KVVWHxWAzr+e+rBuepn2MgC+rb9N6YKH4Wjd3zGwFZhb5nk9JDhKz3D+2le9T KtTB2rp6BzO73vAp65ZLRDprPBUVLMLrziDMdQDw317Xp4f03LQMSFp5UWpmRzozTyeO uQoa6JXiiDo5/OJvRL7/5/UUYQhFn/Z53bNcnQZa8QOC0s+FueGFVBDOZOC53jDNojeb 5vswlbxRhIWmrpelAeiMDUHPGD1BxXNaLgXFUJ2rF3/M01RXL2zEMs8hYML6IHp9G37B UDujDLPJsLv/KFYGMLJzuZdB/CpnlNGSQprMRXTyi5kac15WWf0oTW/QvSN0iLxvvqle NSFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=jPcn8u79; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c2si16168196edq.228.2020.07.07.20.18.10; Tue, 07 Jul 2020 20:18:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=jPcn8u79; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728786AbgGHDOv (ORCPT + 99 others); Tue, 7 Jul 2020 23:14:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728400AbgGHDOu (ORCPT ); Tue, 7 Jul 2020 23:14:50 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD913C061755 for ; Tue, 7 Jul 2020 20:14:50 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id 1so1623950pfn.9 for ; Tue, 07 Jul 2020 20:14:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oAwKqHK24P/HMH2S8nsQQ/C5A8edfnTk57osWeiH3rQ=; b=jPcn8u79M2ubqWOVgArEpIpOZmykPitfCUoGWRa6+qdIOI97B2U6jelnkbvjXAuChZ Z+MmJ0LdTQYzcxBmMKHTCKwjfciCn6vEWhb6CmddE9e2sdVlginnSJcI4hynjLkczzbl LS+umlChhWR4lhCrtRCR4GWrBQVV9t7/5Gyow= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oAwKqHK24P/HMH2S8nsQQ/C5A8edfnTk57osWeiH3rQ=; b=TW5z6HhqzUSfRV9jv4TlMgpbtXVGETdSprDPOVfcQzZTnaux2dz4PkGIGgSjA+8CGo v/NiaJVb0jpzjNvbAH/SsPHB8ewjlou1vpOpr0VJ6BY+J6B+/eeF4RAeqkdOR3+eXH++ EDUyN7LjPmcUTYu/nQEStNUScwCmyB52QxG6FIEIsHNONqkAMRwI680NGfkoCmDLZl2X +cmoeHJnIeopu5sfQQYUak5ep8LH79+MWGdIv1EmcMuAPEPs2FxVIdMLgwJ8N9CnzpwX QK+08O+8lQTB8KlLFzRAKcjcYMPKnszMNj/rJwqrTCC7GtIS0+hH9ekUV+Alo8lfvUyL PTVA== X-Gm-Message-State: AOAM531kShRXcsmbZZqdVUVIOBB7iHBrupZxTNgtZhpq8o2S+XfF8WL7 yi6CKIPPq5N3spCmW/yOFm3Dkg== X-Received: by 2002:a65:6554:: with SMTP id a20mr41872771pgw.301.1594178090263; Tue, 07 Jul 2020 20:14:50 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id y7sm3665683pjp.47.2020.07.07.20.14.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 20:14:49 -0700 (PDT) Date: Tue, 7 Jul 2020 20:14:48 -0700 From: Kees Cook To: Scott Branden Cc: James Morris , Luis Chamberlain , Mimi Zohar , Greg Kroah-Hartman , "Rafael J. Wysocki" , Alexander Viro , Jessica Yu , Dmitry Kasatkin , "Serge E. Hallyn" , Casey Schaufler , "Eric W. Biederman" , Peter Zijlstra , Matthew Garrett , David Howells , Mauro Carvalho Chehab , Randy Dunlap , "Joel Fernandes (Google)" , KP Singh , Dave Olsthoorn , Hans de Goede , Peter Jones , Andrew Morton , Stephen Boyd , Paul Moore , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH 2/4] fs: Remove FIRMWARE_PREALLOC_BUFFER from kernel_read_file() enums Message-ID: <202007072011.91509B7C@keescook> References: <20200707081926.3688096-1-keescook@chromium.org> <20200707081926.3688096-3-keescook@chromium.org> <0a5e2c2e-507c-9114-5328-5943f63d707e@broadcom.com> <202007071447.D96AA42ECE@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 07, 2020 at 08:06:23PM -0700, Scott Branden wrote: > Some people want the header files included in each c file they are used. > Others want header files not included if they are included in another header > file. Ah, yes. That's fine then, leave them in the .c files. -- Kees Cook