Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp238660ybt; Tue, 7 Jul 2020 21:46:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJysPYtuimR8/nhZRw0Jn9HzXQ9aQXxxP+8Fh/ok3vOdtaPrzQ9xUpPjnKjUOkOjTxc/EKk1 X-Received: by 2002:a17:906:840a:: with SMTP id n10mr48320086ejx.453.1594183582767; Tue, 07 Jul 2020 21:46:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594183582; cv=none; d=google.com; s=arc-20160816; b=0mo5lp1d91nyt8d8bBRQfzWmj1K1kaalDqcBfBxaLV9sUrLYGveVvz/Fa1uZn+rOED 6ZIL5wCUFZnxzYHIXGRKWOSgfPLKMLHN4wEgsSFJH/h5+CvqThEE41dOlJUZQgTlVAAk teImcCT5u6Q38wIOzibEURpDxNAsUBAsVlko5XhYUqSArHeIpsMCBBbrgbqe1pXDw82N QwvI4xmPPxfmrsNYQs5vzFXeBSmUAGAGGRDskL7Ld+vJELdK82yrPDbykxhPx0jv5byy w9b42hgA0UD0CQ9clDR4+9lpK9es96R+axqKiPGLsv6axiBjbnbCgEDuCu1Mj/9jJUHn OAZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=rLqyPrHmkwwskxepcX7hcpAy9KCQ3ceDS+STlZ/U0Zo=; b=UR9Olv5sj/LN0fijqeokGNolvx2ONw3PpVZPoBQnVFZZqAXGGRYt+tEAAdZOfdOhh8 UqLblHHO3hshlJXy/UE+QpNDewWkT3g2TpcIG40LiARV5MV9yr41CcF4qwI/oQHsCOHJ JXuYIvsUYnxJuymbXazeYi0RqFAPmwzhEpVSuoYyTLAeXM3Quasq7fTGy5Ak8/gJH021 WCAzN1JfHGzmvsUU4rjIz2HSwokCBldpboQiM8aSaQFi+lJ1yamvNKbHOLBT9SOSV3Jf CSiusPyIhyeC8Yr92ydcIsyIqYcPwFj0MT89Ai8cw3CvQu5AwFGrzmIg1Z7BGzSvJ0F7 QlgQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k19si15764376ejc.167.2020.07.07.21.45.59; Tue, 07 Jul 2020 21:46:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729381AbgGHEi1 (ORCPT + 99 others); Wed, 8 Jul 2020 00:38:27 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:40703 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726185AbgGHEi0 (ORCPT ); Wed, 8 Jul 2020 00:38:26 -0400 Received: by mail-pl1-f193.google.com with SMTP id x11so17644150plo.7; Tue, 07 Jul 2020 21:38:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rLqyPrHmkwwskxepcX7hcpAy9KCQ3ceDS+STlZ/U0Zo=; b=s1CMpuWz3Qqa9b1izEWrOkElyZCNOU9qFgjvI898V5bQ+IoXGBbMwIO+DoksmXmtx5 vDUjWBgH4mppktjbl4m+M/gbjakjQsBFDm/P9tT1DD4073FlW/p8vdo44UCEGVs79qJU diwHpIpsUkLXX6Y8u3hXjaHn1iU1wiyetd3w23yk47x0tAQlXkxjLO0nan7Ha7nvEsa7 KnKu0C8vhsWqXdvjIRFUUIKs+Nu4m9nTdUv30lm5J3NTCFvvv8D2UmxwqkD/jUV/cQeE x8FjsstqhIvKjQCDcdS+QecEWe+OnSkilb+mpRBdSstST+L5Zou70PNCfW/KYB/u/gey GEag== X-Gm-Message-State: AOAM53264Ip0SXINTaGAnRCk8PshnUW8oooTyOWyxQ0YfdAAgogl44fa 97lQH4FLkitD+5oWD94lcqs= X-Received: by 2002:a17:90a:e017:: with SMTP id u23mr7680022pjy.179.1594183105448; Tue, 07 Jul 2020 21:38:25 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id e5sm3979787pjy.26.2020.07.07.21.38.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 21:38:24 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id C7031400DB; Wed, 8 Jul 2020 04:38:23 +0000 (UTC) Date: Wed, 8 Jul 2020 04:38:23 +0000 From: Luis Chamberlain To: Brendan Higgins Cc: jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, arnd@arndb.de, keescook@chromium.org, skhan@linuxfoundation.org, alan.maguire@oracle.com, yzaikin@google.com, davidgow@google.com, akpm@linux-foundation.org, rppt@linux.ibm.com, frowand.list@gmail.com, catalin.marinas@arm.com, will@kernel.org, monstr@monstr.eu, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, chris@zankel.net, jcmvbkbc@gmail.com, gregkh@linuxfoundation.org, sboyd@kernel.org, logang@deltatee.com, linux-um@lists.infradead.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-xtensa@linux-xtensa.org Subject: Re: [PATCH v5 08/12] init: main: add KUnit to kernel init Message-ID: <20200708043823.GZ4332@42.do-not-panic.com> References: <20200626210917.358969-1-brendanhiggins@google.com> <20200626210917.358969-9-brendanhiggins@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200626210917.358969-9-brendanhiggins@google.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 26, 2020 at 02:09:13PM -0700, Brendan Higgins wrote: > Remove KUnit from init calls entirely, instead call directly from > kernel_init(). The commit log does not explain *why*. > Co-developed-by: Alan Maguire > Signed-off-by: Alan Maguire > Signed-off-by: Brendan Higgins > Reviewed-by: Stephen Boyd Other than that: Reviewed-by: Luis Chamberlain Luis