Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andy Duan <fugang.duan@nxp.com>
To:     Sergey Organov <sorganov@gmail.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
Subject: RE: [EXT] [PATCH  4/5] net: fec: get rid of redundant code in
 fec_ptp_set()
Thread-Topic: [EXT] [PATCH  4/5] net: fec: get rid of redundant code in
 fec_ptp_set()
Thread-Index: AQHWU6F5IyIEbIdp8UqiTSGJIl4IMaj7gQmwgACxpduAAPiYUA==
Date:   Wed, 8 Jul 2020 05:34:35 +0000
Message-ID: <AM6PR0402MB36074EB7107ACF728134FEB0FF670@AM6PR0402MB3607.eurprd04.prod.outlook.com>
References: <20200706142616.25192-1-sorganov@gmail.com>
        <20200706142616.25192-5-sorganov@gmail.com>
        <AM6PR0402MB3607DE03C3333B9E4C8D3309FF660@AM6PR0402MB3607.eurprd04.prod.outlook.com>
 <87tuyj8jxx.fsf@osv.gnss.ru>
In-Reply-To: <87tuyj8jxx.fsf@osv.gnss.ru>
Accept-Language: zh-CN, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7fbd8ee1-2211-4ab7-7f72-08d8230099fb
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2020 05:34:36.0215
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cUiPfsf0CTyxSFj7pevHQHbU9njo6/eA+9KUoQY6r+L7i8ib2CUCsy9jV9IDhEuLH7U+EIuuhO14WN9tYLaQdw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3074
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Sergey Organov <sorganov@gmail.com> Sent: Tuesday, July 7, 2020 10:43=
 PM
> Andy Duan <fugang.duan@nxp.com> writes:
>=20
> > From: Sergey Organov <sorganov@gmail.com> Sent: Monday, July 6, 2020
> 10:26 PM
> >> Code of the form "if(x) x =3D 0" replaced with "x =3D 0".
> >>
> >> Code of the form "if(x =3D=3D a) x =3D a" removed.
> >>
> >> Signed-off-by: Sergey Organov <sorganov@gmail.com>
> >> ---
> >>  drivers/net/ethernet/freescale/fec_ptp.c | 4 +---
> >>  1 file changed, 1 insertion(+), 3 deletions(-)
> >>
> >> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c
> >> b/drivers/net/ethernet/freescale/fec_ptp.c
> >> index e455343..4152cae 100644
> >> --- a/drivers/net/ethernet/freescale/fec_ptp.c
> >> +++ b/drivers/net/ethernet/freescale/fec_ptp.c
> >> @@ -485,9 +485,7 @@ int fec_ptp_set(struct net_device *ndev, struct
> ifreq
> >> *ifr)
> >>
> >>         switch (config.rx_filter) {
> >>         case HWTSTAMP_FILTER_NONE:
> >> -               if (fep->hwts_rx_en)
> >> -                       fep->hwts_rx_en =3D 0;
> >> -               config.rx_filter =3D HWTSTAMP_FILTER_NONE;
> > The line should keep according your commit log.
>=20
> You mean I should fix commit log like this:
>=20
> Code of the form "switch(x) case a: x =3D a; break" removed.
>=20
> ?
Like this:

case HWTSTAMP_FILTER_NONE:
	fep->hwts_rx_en =3D 0;
	config.rx_filter =3D HWTSTAMP_FILTER_NONE;
	break;
>=20
> I'll do if it's cleaner that way.
>=20
> Thanks,
> -- Sergey
>=20
>=20
> >
> >> +               fep->hwts_rx_en =3D 0;
> >>                 break;
> >>
> >>         default:
> >> --
> >> 2.10.0.1.g57b01a3