Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932143AbWEATDR (ORCPT ); Mon, 1 May 2006 15:03:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932195AbWEATDR (ORCPT ); Mon, 1 May 2006 15:03:17 -0400 Received: from mx.pathscale.com ([64.160.42.68]:38809 "EHLO mx.pathscale.com") by vger.kernel.org with ESMTP id S932143AbWEATDQ (ORCPT ); Mon, 1 May 2006 15:03:16 -0400 Subject: Re: [PATCH 5 of 13] ipath - use proper address translation routine From: "Bryan O'Sullivan" To: Roland Dreier Cc: openib-general@openib.org, linux-kernel@vger.kernel.org In-Reply-To: References: <1ab168913f0fea5d18b4.1145913781@eng-12.pathscale.com> Content-Type: text/plain Date: Mon, 01 May 2006 12:03:16 -0700 Message-Id: <1146510196.4544.1.camel@chalcedony.pathscale.com> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 (2.6.1-1.fc5.2) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 783 Lines: 22 On Mon, 2006-05-01 at 11:50 -0700, Roland Dreier wrote: > Bryan> Move away from an obsolete, unportable routine for > Bryan> translating physical addresses. > > This change: > > > - isge->vaddr = bus_to_virt(sge->addr); > > + isge->vaddr = phys_to_virt(sge->addr); > > is really wrong. bus_to_virt() is really what you want, because in > this case the address is a bus address that came from dma_map_xxx(). Well, bus_to_virt is not portable, so we definitely can't use it. I'll have to do some thinking about this.