Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp306281ybt; Wed, 8 Jul 2020 00:00:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwgPnc60iolHMGXXCYMjqgk+T1nEWETJ5oPckhfPQvZJG9M2SxkcY9hSw/LgLyCDfqpEUJ X-Received: by 2002:a50:9f6a:: with SMTP id b97mr63726631edf.322.1594191615378; Wed, 08 Jul 2020 00:00:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594191615; cv=none; d=google.com; s=arc-20160816; b=j+I8WPnE35K7iZn1T6DBLvt29v60Q/oFs7vfX0rQ+l1aiwLryUlPjYN/8Q8kk/YQqz 7W5dE0QEL+1Cx9rJrSnqKghTtjs73Ta9Tfvl3RApUHt+5betMoOLI2UaYM5HfUI+HFYz UShlLR87F32NsTGD8QcIxVySQamuhrbEA1xe+dY0DTHJFC4AGKtmihmRZuee86H016sU KyDWoKgfZA1VmaBl28wTa504auZe96l4gfcNHi06bM27EtxjYeYWo6gI580Q5r670AFu Ysf4Ml+lMbMX8VnHv0L6t/MfJymrhEx58ZKCFJfc9Nwe+O2cBMdGP56mWT3A3QWhhzYO ik4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:from:references:cc:to:subject :dkim-signature; bh=Az+NbGEqpxE1mhacuWneq+VUUYoQV1fpfa73pWlsTG8=; b=F0oJh6/45BU53f0qjxrVBSwlIgdrFwvmF33LgKa9d7Q+x3YeXmdnXnWIIMF8yWxcIK HumB2jcoLAWGjyUr8jna7yU9lCtRjx+t+nP+kFtxrq8GFvaKHWWj4rjPgO8XabgVnSw/ MU8opjTfTgUWlGG3ClMU8+EI/KGtZr51fonw9Uf5frhK6wBNJHi6FQrmekuU/xQiqA7T 3qeEpY4WRqTH+/jlFJbmlV3dYmtb3gEXbkHojG1nb9mqlRbo2GnyLm1GgzhYp2rFLVX5 iq7gu1+Bu2inc4jB5YScGTTSHFzjzGDoV3uN/lxjbKZTnSfGlorbyK7lnUWWx3BLslCg 1zPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MfH3Gjg9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r12si15575046ejr.473.2020.07.07.23.59.52; Wed, 08 Jul 2020 00:00:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MfH3Gjg9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729761AbgGHG7c (ORCPT + 99 others); Wed, 8 Jul 2020 02:59:32 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:36320 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726194AbgGHG7b (ORCPT ); Wed, 8 Jul 2020 02:59:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594191568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Az+NbGEqpxE1mhacuWneq+VUUYoQV1fpfa73pWlsTG8=; b=MfH3Gjg9gfDI97WkbRU4YYogv4L9zJ6IPHURFsLzzqWMYDWiK+EkNCjqiffZQZI4U7CiOr h3aAKK98cYak5epLOwJOz+0L4F3dhoPIBcnR0C5YVhrDZOMIONm6oXE8owF+w5UuTaMq6L EtlFGygcH38E7hJcteZGJSUtWLz3lAc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-276-_TFbW2XVPn-VrCKTbkvjFg-1; Wed, 08 Jul 2020 02:59:25 -0400 X-MC-Unique: _TFbW2XVPn-VrCKTbkvjFg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 076AF805EF3; Wed, 8 Jul 2020 06:59:23 +0000 (UTC) Received: from [10.36.113.117] (ovpn-113-117.ams2.redhat.com [10.36.113.117]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6CE2B5BAC3; Wed, 8 Jul 2020 06:59:19 +0000 (UTC) Subject: Re: [PATCH v2 1/3] arm64/numa: export memory_add_physaddr_to_nid as EXPORT_SYMBOL_GPL To: Mike Rapoport , Dan Williams Cc: Justin He , Michal Hocko , Catalin Marinas , Will Deacon , Vishal Verma , Dave Jiang , Andrew Morton , Baoquan He , Chuhong Yuan , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-nvdimm@lists.01.org" , Kaly Xin References: <20200707055917.143653-1-justin.he@arm.com> <20200707055917.143653-2-justin.he@arm.com> <20200707115454.GN5913@dhcp22.suse.cz> <20200708062217.GE386073@linux.ibm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= mQINBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABtCREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT6JAlgEEwEIAEICGwMFCQlmAYAGCwkIBwMCBhUI AgkKCwQWAgMBAh4BAheAFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl3pImkCGQEACgkQTd4Q 9wD/g1o+VA//SFvIHUAvul05u6wKv/pIR6aICPdpF9EIgEU448g+7FfDgQwcEny1pbEzAmiw zAXIQ9H0NZh96lcq+yDLtONnXk/bEYWHHUA014A1wqcYNRY8RvY1+eVHb0uu0KYQoXkzvu+s Dncuguk470XPnscL27hs8PgOP6QjG4jt75K2LfZ0eAqTOUCZTJxA8A7E9+XTYuU0hs7QVrWJ jQdFxQbRMrYz7uP8KmTK9/Cnvqehgl4EzyRaZppshruKMeyheBgvgJd5On1wWq4ZUV5PFM4x II3QbD3EJfWbaJMR55jI9dMFa+vK7MFz3rhWOkEx/QR959lfdRSTXdxs8V3zDvChcmRVGN8U Vo93d1YNtWnA9w6oCW1dnDZ4kgQZZSBIjp6iHcA08apzh7DPi08jL7M9UQByeYGr8KuR4i6e RZI6xhlZerUScVzn35ONwOC91VdYiQgjemiVLq1WDDZ3B7DIzUZ4RQTOaIWdtXBWb8zWakt/ ztGhsx0e39Gvt3391O1PgcA7ilhvqrBPemJrlb9xSPPRbaNAW39P8ws/UJnzSJqnHMVxbRZC Am4add/SM+OCP0w3xYss1jy9T+XdZa0lhUvJfLy7tNcjVG/sxkBXOaSC24MFPuwnoC9WvCVQ ZBxouph3kqc4Dt5X1EeXVLeba+466P1fe1rC8MbcwDkoUo65Ag0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAGJAiUEGAECAA8FAlXLn5ECGwwFCQlmAYAACgkQTd4Q 9wD/g1qA6w/+M+ggFv+JdVsz5+ZIc6MSyGUozASX+bmIuPeIecc9UsFRatc91LuJCKMkD9Uv GOcWSeFpLrSGRQ1Z7EMzFVU//qVs6uzhsNk0RYMyS0B6oloW3FpyQ+zOVylFWQCzoyyf227y GW8HnXunJSC+4PtlL2AY4yZjAVAPLK2l6mhgClVXTQ/S7cBoTQKP+jvVJOoYkpnFxWE9pn4t H5QIFk7Ip8TKr5k3fXVWk4lnUi9MTF/5L/mWqdyIO1s7cjharQCstfWCzWrVeVctpVoDfJWp 4LwTuQ5yEM2KcPeElLg5fR7WB2zH97oI6/Ko2DlovmfQqXh9xWozQt0iGy5tWzh6I0JrlcxJ ileZWLccC4XKD1037Hy2FLAjzfoWgwBLA6ULu0exOOdIa58H4PsXtkFPrUF980EEibUp0zFz GotRVekFAceUaRvAj7dh76cToeZkfsjAvBVb4COXuhgX6N4pofgNkW2AtgYu1nUsPAo+NftU CxrhjHtLn4QEBpkbErnXQyMjHpIatlYGutVMS91XTQXYydCh5crMPs7hYVsvnmGHIaB9ZMfB njnuI31KBiLUks+paRkHQlFcgS2N3gkRBzH7xSZ+t7Re3jvXdXEzKBbQ+dC3lpJB0wPnyMcX FOTT3aZT7IgePkt5iC/BKBk3hqKteTnJFeVIT7EC+a6YUFg= Organization: Red Hat GmbH Message-ID: Date: Wed, 8 Jul 2020 08:59:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200708062217.GE386073@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08.07.20 08:22, Mike Rapoport wrote: > On Tue, Jul 07, 2020 at 09:27:43PM -0700, Dan Williams wrote: >> On Tue, Jul 7, 2020 at 9:08 PM Justin He wrote: >> [..] >>>> Especially for architectures that use memblock info for numa info >>>> (which seems to be everyone except x86) why not implement a generic >>>> memory_add_physaddr_to_nid() that does: >>>> >>>> int memory_add_physaddr_to_nid(u64 addr) >>>> { >>>> unsigned long start_pfn, end_pfn, pfn = PHYS_PFN(addr); >>>> int nid; >>>> >>>> for_each_online_node(nid) { >>>> get_pfn_range_for_nid(nid, &start_pfn, &end_pfn); >>>> if (pfn >= start_pfn && pfn <= end_pfn) >>>> return nid; >>>> } >>>> return NUMA_NO_NODE; >>>> } >>> >>> Thanks for your suggestion, >>> Could I wrap the codes and let memory_add_physaddr_to_nid simply invoke >>> phys_to_target_node()? >> >> I think it needs to be the reverse. phys_to_target_node() should call >> memory_add_physaddr_to_nid() by default, but fall back to searching >> reserved memory address ranges in memblock. See phys_to_target_node() >> in arch/x86/mm/numa.c. That one uses numa_meminfo instead of memblock, >> but the principle is the same i.e. that a target node may not be >> represented in memblock.memory, but memblock.reserved. I'm working on >> a patch to provide a function similar to get_pfn_range_for_nid() that >> operates on reserved memory. > > Do we really need yet another memblock iterator? > I think only x86 has memory that is not in memblock.memory but only in > memblock.reserved. Reading about abusing the memblock allcoator once again in memory hotplug paths makes me shiver. -- Thanks, David / dhildenb