Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp316359ybt; Wed, 8 Jul 2020 00:16:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzXfy8NSy5xaj48pmKbBdZVWk44zJtqXsah8NstOWz8lf7x4MUhbXjNV8A+aQgENRLwR8yy X-Received: by 2002:a05:6402:2d7:: with SMTP id b23mr53284730edx.145.1594192595634; Wed, 08 Jul 2020 00:16:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594192595; cv=none; d=google.com; s=arc-20160816; b=bMfwwK4g1T1rKd7yJfNP5zNFnuYtsf7tbh4+KWIPUK72obCug0B0zBDbCi7JL83OTT xmTh7sQSgxmfFGbAjzij7UEftZV3sZtR0r+62oiqWm4Pq6yDxyvBZxvNkDSsx2qBubxn 9rkfQvPvzU+TTae28bpXdP2OuveCTJAwoRpkPxST4fSKicc8dhhKsU6BY73vL3mn2qEX 9Av9hyWsHNgp7WcR9v37N/MxvGDHK6BN8mfY/QloO4hHESMhZ94SyGoge6Bc83E52dJW PZzP56jqOKUuPZRVDw5wxsaAB9wMyNL6hxmTKZbdpQ7amlMfHFkiwQlB7LPSseo9G1cD POWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=XRilmb1Jngnk7k/9K5uAaSX/0kCWr8sNf6kcRHVMY8w=; b=rO8aHvJw+uTS3dK3e7IwCVuu3cywo7iECYUuwDhokt+tvaPbDzi0Xz4Qrh8vlAKHaQ GHMisOJS7cYnCu960K8BXwOBlOpk/6orTKvqzOTvlbp9XpdxR4WKNzIE3HzxyHExA2yf 6r6/8CxHGM3kGMm0N3qSycqVDbxB0LLCSgkTQAYD4r2MpDh2JrfO8jZqugdJeonV2Hn7 421tQP047fhJcaUcWLpk8WGW407c+unTponhrqmWWn0IbbKJM0zsKgINE2SyaS1JWSGb i6/EXQbkv7HF6WmFn5wBT+CePFWBp4/nJhyhhLtOWEqY2gUOtq8HuCGVGWuniPCQqXlM G7BA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pNTkKnbb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rv2si15581109ejb.428.2020.07.08.00.16.11; Wed, 08 Jul 2020 00:16:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pNTkKnbb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729861AbgGHHPO (ORCPT + 99 others); Wed, 8 Jul 2020 03:15:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729740AbgGHHPN (ORCPT ); Wed, 8 Jul 2020 03:15:13 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37635C061755 for ; Wed, 8 Jul 2020 00:15:13 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id f5so37071822ljj.10 for ; Wed, 08 Jul 2020 00:15:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XRilmb1Jngnk7k/9K5uAaSX/0kCWr8sNf6kcRHVMY8w=; b=pNTkKnbb3hm+A+HQN5rOzozN/kmm1vVVSMgCB0LBOI8R1nunHbWZwUEelAOtheH0GO wO9AabHTuWsSBZT8qzYUHWZuSppM3d3h//+tF8HbkX7cOcVKJ2+Ey98jOPgRmMqHt/vu 4O1LSHNgxdIxTbmQRRpInCaRmZCJ+fTbaJSIJ7KuDK+Ay/NvlJtdK4rcbkmhHF1COedM YGrkeGmvEEDEwRrXDB8bh152Vv9mLFwWrVMhObHQQnGIrEmx20tA5aiyFWT0YP66APeE vQ6d9VW4N0kft+tfC+ZUyoSW0HkLv9E0Y8RkFioicZhrfo/a+kNPCjn+PFvhBzFbSjRI 817g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XRilmb1Jngnk7k/9K5uAaSX/0kCWr8sNf6kcRHVMY8w=; b=XGowUVcuQmB8drL1Ngr3e2mtc63UfsumvGsN9PvZUEnB1YebKuCZpnVJ7lHOfjfc8t ZBSgtbgPCiX3+szglRirZIA7+9Q8bj4HzaQEvUP5C6KhR6kt8SHN6dcVgWQXPJCeq8U/ 1RBYCdkSXt2U7Cl5pgUFTDboaItVeHgncsRIVm03E46pcTXctIcIRILM/pJ1Eezp97ZN S55q6tywkwCWBI9yHyDPa1UAh79b4WvJwZX4gw10NbCk47KX17bgtCadhI5JvFo7/Pqs DX2NJ0ZEjxEL0wl7nfeSYiRVvUd4x5/86FSnpk3e2GQZrA9UQlas7hWhLlCDN3MFNhUN 38eg== X-Gm-Message-State: AOAM531EoQI7LrwtER2vR2MrVD+hY9tw+YeZ31267t8FwNNGAfZ0WeMV IjnCY9KrXQySqwxn32/ic89gXB5mT8DHjpAoPZKeSQ== X-Received: by 2002:a2e:9a4d:: with SMTP id k13mr11201719ljj.283.1594192511738; Wed, 08 Jul 2020 00:15:11 -0700 (PDT) MIME-Version: 1.0 References: <20200630133345.2232932-1-lee.jones@linaro.org> <20200630133345.2232932-3-lee.jones@linaro.org> In-Reply-To: <20200630133345.2232932-3-lee.jones@linaro.org> From: Linus Walleij Date: Wed, 8 Jul 2020 09:15:01 +0200 Message-ID: Subject: Re: [PATCH 02/10] gpio: gpio-altera: Add missing kerneldoc entry and demote comment To: Lee Jones Cc: Bartosz Golaszewski , Linux ARM , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , Joyce Ooi , Tien Hock Loh Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 30, 2020 at 3:33 PM Lee Jones wrote: > 'struct altera_gpio_chip's 'irq_chip' property is undocumented. So > add property description to the struct's kerneldoc header. Also > demote comment block which is clearly not in kerneldoc format. > > Fixes the following W=1 warnings: > > drivers/gpio/gpio-altera.c:34: warning: Function parameter or member 'irq_chip' not described in 'altera_gpio_chip' > drivers/gpio/gpio-altera.c:78: warning: Function parameter or member 'd' not described in 'altera_gpio_irq_set_type' > drivers/gpio/gpio-altera.c:78: warning: Function parameter or member 'type' not described in 'altera_gpio_irq_set_type' > > Cc: Joyce Ooi > Cc: Tien Hock Loh > Signed-off-by: Lee Jones Patch applied! Yours, Linus Walleij