Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp321347ybt; Wed, 8 Jul 2020 00:26:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxR5Vz5lh9LNnILDWXeTN8rHcD1eiyu/yPJKnFL2CekmWry7PwzTDrJuq/nWKGh2Bkab7hH X-Received: by 2002:a17:906:2a5b:: with SMTP id k27mr49020974eje.82.1594193176890; Wed, 08 Jul 2020 00:26:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594193176; cv=none; d=google.com; s=arc-20160816; b=GgCEergXWB43OnlWL7hn+ZouIfIjQg3x+0U6bwn3S1B6TQ4cI5JI5tajHda/CVuiXi wOB3hKDS+tVuA+j2J0QasXhDh2mT1jgjdo0/8pDSo/djUCkpthC9rJxigotJ67WbpBvc Zuv/34V0VjUfu/SOXXSrixn1QSykenHzWls+22V5AoeDoRZmu25QifGctjR/b9XiYLQc zJaNRSvmsAzhORUkIfajsIs4P34olgCDN1N0718ZWjbRdLCf1M9ldk3R9nvyPc+1kYP3 UKrybW9hAs2I0h9e34DLAmUTdBDk9e1VibLdMB0rcq0muokLxJXrnALICki6a7RHwaDI y+0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:ironport-sdr:ironport-sdr; bh=lqH7oXzblDVO7M5eTW48Hb5XCyKqXzsiTTDiViyOsFE=; b=bZkZwYdkzzOan+FlbtjSUE5IW7IyYCOcBHTQ6+btzkX5HwbxiLLMGlxKEYreCc99/Q vFZgon/YytZwGQYfIFHToTDd6XylX9wVmGkWvsCjQFz0ZYnuu9jHMWPsSw+tj4kpXC/z tQqwkwpBDHL3BPMsoNswjiV5eea5EAqWSSuSBJsuvz0ClVQBTd6IailKgejZHAcF+JIt fLppIjKSWpsmnYpOR0kBUtR/RzYD6OQhdCLjrXzK/QL2vZLTTrh6ANu+RhT5GrzRZcw2 gQDe1tLg1QG003uEQZHKy9tzxdr1uhMWrIMb7MsYSLA947/RJKE0sQXy41z9xskBZOOM cg9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jr6si16402614ejb.259.2020.07.08.00.25.54; Wed, 08 Jul 2020 00:26:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730435AbgGHHZL (ORCPT + 99 others); Wed, 8 Jul 2020 03:25:11 -0400 Received: from mga09.intel.com ([134.134.136.24]:60669 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730009AbgGHHZK (ORCPT ); Wed, 8 Jul 2020 03:25:10 -0400 IronPort-SDR: g674s7xNsq7iIi5nNgdgMS+f21u8RY9Nj2enR21uTXAez+kXJHGDbuNnrzfJCYEuwb+FxOIbuJ FK5bjaZRtyzA== X-IronPort-AV: E=McAfee;i="6000,8403,9675"; a="149264568" X-IronPort-AV: E=Sophos;i="5.75,327,1589266800"; d="scan'208";a="149264568" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2020 00:25:10 -0700 IronPort-SDR: IHLstHTu5jVziUO1pU/soYmb40/w43VTxZjztC2FZFX2WCyseitXo4j9Fk3uh5jaGZAAU2ZrzR 16h/h2Rovyuw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,327,1589266800"; d="scan'208";a="358025085" Received: from pg-nxl3.altera.com ([10.142.129.93]) by orsmga001.jf.intel.com with ESMTP; 08 Jul 2020 00:25:03 -0700 From: "Ooi, Joyce" To: Thor Thayer , "David S . Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Dalon Westergreen , Joyce Ooi , Tan Ley Foon , See Chin Liang , Dinh Nguyen , Dalon Westergreen Subject: [PATCH v4 03/10] net: eth: altera: fix altera_dmaops declaration Date: Wed, 8 Jul 2020 15:23:54 +0800 Message-Id: <20200708072401.169150-4-joyce.ooi@intel.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20200708072401.169150-1-joyce.ooi@intel.com> References: <20200708072401.169150-1-joyce.ooi@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dalon Westergreen The declaration of struct altera_dmaops does not have identifier names. Add identifier names to confrom with required coding styles. Signed-off-by: Dalon Westergreen Signed-off-by: Joyce Ooi --- v2: no change v3: no change v4: no change --- drivers/net/ethernet/altera/altera_tse.h | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/altera/altera_tse.h b/drivers/net/ethernet/altera/altera_tse.h index f17acfb579a0..7d0c98fc103e 100644 --- a/drivers/net/ethernet/altera/altera_tse.h +++ b/drivers/net/ethernet/altera/altera_tse.h @@ -385,20 +385,22 @@ struct altera_tse_private; struct altera_dmaops { int altera_dtype; int dmamask; - void (*reset_dma)(struct altera_tse_private *); - void (*enable_txirq)(struct altera_tse_private *); - void (*enable_rxirq)(struct altera_tse_private *); - void (*disable_txirq)(struct altera_tse_private *); - void (*disable_rxirq)(struct altera_tse_private *); - void (*clear_txirq)(struct altera_tse_private *); - void (*clear_rxirq)(struct altera_tse_private *); - int (*tx_buffer)(struct altera_tse_private *, struct tse_buffer *); - u32 (*tx_completions)(struct altera_tse_private *); - void (*add_rx_desc)(struct altera_tse_private *, struct tse_buffer *); - u32 (*get_rx_status)(struct altera_tse_private *); - int (*init_dma)(struct altera_tse_private *); - void (*uninit_dma)(struct altera_tse_private *); - void (*start_rxdma)(struct altera_tse_private *); + void (*reset_dma)(struct altera_tse_private *priv); + void (*enable_txirq)(struct altera_tse_private *priv); + void (*enable_rxirq)(struct altera_tse_private *priv); + void (*disable_txirq)(struct altera_tse_private *priv); + void (*disable_rxirq)(struct altera_tse_private *priv); + void (*clear_txirq)(struct altera_tse_private *priv); + void (*clear_rxirq)(struct altera_tse_private *priv); + int (*tx_buffer)(struct altera_tse_private *priv, + struct tse_buffer *buffer); + u32 (*tx_completions)(struct altera_tse_private *priv); + void (*add_rx_desc)(struct altera_tse_private *priv, + struct tse_buffer *buffer); + u32 (*get_rx_status)(struct altera_tse_private *priv); + int (*init_dma)(struct altera_tse_private *priv); + void (*uninit_dma)(struct altera_tse_private *priv); + void (*start_rxdma)(struct altera_tse_private *priv); }; /* This structure is private to each device. -- 2.13.0