Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp334080ybt; Wed, 8 Jul 2020 00:51:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzM9pb1A9HxD07GyllAY1BFTHcN7rTXE4hA3r/v42iYaq9QR0gf1wdQx2QMdeaacxZ0Fy8I X-Received: by 2002:aa7:da06:: with SMTP id r6mr55196826eds.189.1594194673487; Wed, 08 Jul 2020 00:51:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594194673; cv=none; d=google.com; s=arc-20160816; b=CDhjTnz3sQ3vYig3bJ97q/HX+ZhdNUkfScW7nydY3fdgZLJf4y0qKtvZdtvIEhAGzO sqTcLXupgEpok067dWUb8IM/82kz0f5yyX4lCv9oGJdIakclFWGzkJn9wEpBHxGShAlq kRmkpL8mXoMJkkAwwlR7DD7hc2R8W8xUIQwgr1jNef0C82LLh99H/TqdFc0EIPsYaTLp wT+hgiLZJTE7EFLyqQgJJQmRE9S5hWNbaFZ+4W3qtH71Zze8opob3oWIIyPJ7OQ6++at Jj1WyYOgFXL7GZfhaZj/cd8fdSOAMB59U2KJmSSt/s9PC33cBHermo31MrA4vXx+r7fN R4Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:message-id:date:cc:to:from:subject:ironport-sdr :ironport-sdr; bh=h+CUwEg/zI1JZ7Z7SvG64CJeE37BKAQpiUhl8NDgrUo=; b=eZ/IMtBwivtQ/HNxhPKZkNqGl3LV9ArfF3bbIh1ojjX9IOc6Dxh1D26CNLcWqnNyu0 K6qYlNDEu1b0GHFjNnElagJ5gMRTs4R3TO1TtVhNLlGmsgOkeRXV709Osx6vbIQ8xf+E gkpSpEwTfcuvE+aKsjS1ukfMtHVPILeBL8U58YEQdRJ0m1t4IM+aiaVzkLZ4pbVHZWo8 yY/2Mj9tle/03YfhcDli95NQBy0+zBVfqtVNKtnawVCrmASZZBh0g9mlfDQCZU/02Y8U ruSXjS6k2qFk2vSJToQCXTW1L2WEg3wHKskuBaqGZCifBkkiksxskfj9ShMppBst0/uH fPpg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn9si12326904edb.344.2020.07.08.00.50.50; Wed, 08 Jul 2020 00:51:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726440AbgGHHkR (ORCPT + 99 others); Wed, 8 Jul 2020 03:40:17 -0400 Received: from mga02.intel.com ([134.134.136.20]:59264 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726325AbgGHHkQ (ORCPT ); Wed, 8 Jul 2020 03:40:16 -0400 IronPort-SDR: 1a5aKT8xMSlhQXHO6S4W7lgsE3gyMWspNy7sWNGjTS2IUwjp9fd3o2rf/A3a5NnSnkFYh9+7mr 9KXaoCuFAC0A== X-IronPort-AV: E=McAfee;i="6000,8403,9675"; a="135987231" X-IronPort-AV: E=Sophos;i="5.75,327,1589266800"; d="scan'208";a="135987231" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2020 00:40:15 -0700 IronPort-SDR: 0BNwvH/Nkcgs0L+wvIjDHLaUfWVlMrGWb3i937k60JLdqFlfYD7iVArx7w0LrXDesZQFAcdZPx TZSN6NUPHmZA== X-IronPort-AV: E=Sophos;i="5.75,327,1589266800"; d="scan'208";a="358028162" Received: from dwillia2-desk3.jf.intel.com (HELO dwillia2-desk3.amr.corp.intel.com) ([10.54.39.16]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2020 00:40:15 -0700 Subject: [PATCH v2] CodingStyle: Inclusive Terminology From: Dan Williams To: corbet@lwn.net Cc: Randy Dunlap , Dave Airlie , Kees Cook , SeongJae Park , Olof Johansson , Chris Mason , Greg Kroah-Hartman , torvalds@linux-foundation.org, tech-board-discuss@lists.linuxfoundation.org, ksummit-discuss@lists.linuxfoundation.org, linux-kernel@vger.kernel.org Date: Wed, 08 Jul 2020 00:23:59 -0700 Message-ID: <159419296487.2464622.863943877093636532.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: StGit/0.18-3-g996c MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linux maintains a coding-style and its own idiomatic set of terminology. Update the style guidelines to recommend replacements for the terms master/slave and blacklist/whitelist. Link: http://lore.kernel.org/r/159389297140.2210796.13590142254668787525.stgit@dwillia2-desk3.amr.corp.intel.com Cc: Jonathan Corbet Acked-by: Randy Dunlap Acked-by: Dave Airlie Acked-by: Kees Cook Acked-by: SeongJae Park Signed-off-by: Olof Johansson Signed-off-by: Chris Mason Signed-off-by: Greg Kroah-Hartman Signed-off-by: Dan Williams --- Changes since v1 [1] - Drop inclusive-terminology.rst, it is in the lore archives if the arguments are needed for future debates, but otherwise no pressing need to carry it in the tree (Linus, James) - Update the recommended terms to include replacement for 'master' and 'whitelist' (Kees, Andy) - Add 'target' as a replacement (Andy) - Add 'device' as a replacement (Mark) - Collect acks and signed-off-bys. Yes, the sign-offs are not reflective of a submission chain, but I kept "Signed-off-by" if people offered it. - Non-change: I did not add explicit language as to what to do with existing usages. My personal inclination is to prioritize this coding-style cleanup higher than others, but the coding-style document has typically not indicated policy on how cleanups are handled by subsystems. It will be a case by case effort and consideration. [1]: http://lore.kernel.org/r/159389297140.2210796.13590142254668787525.stgit@dwillia2-desk3.amr.corp.intel.com Documentation/process/coding-style.rst | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst index 2657a55c6f12..a5b61e9005ac 100644 --- a/Documentation/process/coding-style.rst +++ b/Documentation/process/coding-style.rst @@ -319,6 +319,19 @@ If you are afraid to mix up your local variable names, you have another problem, which is called the function-growth-hormone-imbalance syndrome. See chapter 6 (Functions). +For symbol names, avoid introducing new usage of 'master/slave' (or +'slave' independent of 'master') and 'blacklist/whitelist'. Recommended +replacements for 'master/slave' are: 'main/{secondary,subordinate}', +'primary/replica', '{initiator,requester}/{target,responder}', +'host/{device,proxy}', or 'leader/{performer,follower}'. Recommended +replacements for 'blacklist/whitelist' are: 'denylist/allowlist' or +'blocklist/passlist'. + +Exceptions for introducing new usage is to maintain a userspace ABI/API, +or when updating code for an existing (as of 2020) hardware or protocol +specification that mandates those terms. For new specifications +translate specification usage of the terminology to the kernel coding +standard where possible. 5) Typedefs -----------