Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp355676ybt; Wed, 8 Jul 2020 01:27:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/cTdk1C+DmnWBE1UgDu8D7E+CFwkLlXZn6dEKwwiH6sHXTc+5EXxCNrbUZB6S0vMAdt+d X-Received: by 2002:a17:906:b0d:: with SMTP id u13mr48285410ejg.342.1594196848862; Wed, 08 Jul 2020 01:27:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594196848; cv=none; d=google.com; s=arc-20160816; b=bH1xBxVyeFsiRtwLITKcx0jVo5ypG8+W86vATOu5wlZ3WIiFEKBDy2avOZl6r0deKp IYUnM1blSBk8N4zIaSDQ94gEUpFl9Yl8gg0ByNw1bsI0PxG66+yISrclbyQ90M2AcIji Wj/Km8QvZrOQVth8n1nXTWKchm6kVFCO4Es1t9IOorXzSegB7ppdNXNxEUsskrdQbCuc DTVjAJUnvSG5hPnnccN7EwtjaWkyCkJBGE623KZz4yVFsfqRuAcVaZzZLR/T3cB1UJZz /piTYlFzgBRG07DwEueARVOxd9G3KbETMvYW05WcW38hxOc/o+kxt7JctiMsCP9fiPaG 95iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:to:from; bh=Oz6u+SYcRC13md3EmJmDyc0HhXatrC2NwB31hXfvELE=; b=YJJ6ijfVgU0k1VegHrAKLUcBsYAGPxb6Birm2qhru7efziHHFCcfoU79J3ZPfK0MYi rxvz1ywzFKsJU5qI+TzuGjSgqKg8YToGj5pVF/D5/Wv3IW/6SGBFfZs+a2NUxGAvxhIQ 15rVAUqzMS10PCU6yKSfRSgwCaUqjoKHClJWezgQP/lqrk0AB/MB8i7edGhddn4+5Vpr uCvHQ8KOnR17YRO4vQAcJ0/Hmw9vmtivqb3kwsghKc7zdyEGP/GPQ/e/urPm8MTRvMBY VB2JTAXLZbCBlEMp7gcs9nfKuAefTDzxGDYkCykGWqb5nkD96oa4zMqWg+izEZkcVq3B x8hg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k19si16007360ejc.167.2020.07.08.01.27.06; Wed, 08 Jul 2020 01:27:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727108AbgGHIQq (ORCPT + 99 others); Wed, 8 Jul 2020 04:16:46 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:44413 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725747AbgGHIQq (ORCPT ); Wed, 8 Jul 2020 04:16:46 -0400 Received: from [221.218.144.55] (helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jt5Fw-0005Kj-QZ; Wed, 08 Jul 2020 08:16:42 +0000 From: Aaron Ma To: harry.wentland@amd.com, sunpeng.li@amd.com, alexander.deucher@amd.com, christian.koenig@amd.com, airlied@linux.ie, daniel@ffwll.ch, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, mapengyu@gmail.com, aaron.ma@canonical.com Subject: [PATCH] drm/amd/display: add dmcub check on RENOIR Date: Wed, 8 Jul 2020 04:16:22 -0400 Message-Id: <20200708081622.3109902-1-aaron.ma@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org RENOIR loads dmub fw not dmcu, check dmcu only will prevent loading iram, it breaks backlight control. Bug: https://bugzilla.kernel.org/show_bug.cgi?id=208277 Signed-off-by: Aaron Ma --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 10ac8076d4f2..db5e0bb0d935 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -1358,7 +1358,7 @@ static int dm_late_init(void *handle) struct dmcu *dmcu = NULL; bool ret; - if (!adev->dm.fw_dmcu) + if (!adev->dm.fw_dmcu && !adev->dm.dmub_fw) return detect_mst_link_for_all_connectors(adev->ddev); dmcu = adev->dm.dc->res_pool->dmcu; -- 2.25.1