Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200701120402.6444-1-yannick.fertre@st.com> <3b6e02b8-0f54-4eb0-9728-b304a1aa85d5@st.com>
In-Reply-To: <3b6e02b8-0f54-4eb0-9728-b304a1aa85d5@st.com>
From:   Benjamin Gaignard <benjamin.gaignard@linaro.org>
Date:   Wed, 8 Jul 2020 11:49:59 +0200
Message-ID: <CA+M3ks4Bb8ZHzYSZ0v86PvE3x=C30Gmi+mDVJ=PQ7uzPZ8x-+w@mail.gmail.com>
Subject: Re: [PATCH] drm/stm: ltdc: remove call of pm-runtime functions
To:     Philippe CORNU <philippe.cornu@st.com>
Cc:     Yannick FERTRE <yannick.fertre@st.com>,
        Benjamin GAIGNARD <benjamin.gaignard@st.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre TORGUE <alexandre.torgue@st.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Le jeu. 2 juil. 2020 =C3=A0 14:18, Philippe CORNU <philippe.cornu@st.com> a=
 =C3=A9crit :
>
>
>
> On 7/1/20 2:04 PM, Yannick Fertre wrote:
> > It is not necessary to suspend or stop the ltdc clocks
> > to modify the pixel clock.
> >
> > Signed-off-by: Yannick Fertre <yannick.fertre@st.com>
> > ---
> >   drivers/gpu/drm/stm/ltdc.c | 16 ----------------
> >   1 file changed, 16 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> > index 3f590d916e91..6e28f707092f 100644
> > --- a/drivers/gpu/drm/stm/ltdc.c
> > +++ b/drivers/gpu/drm/stm/ltdc.c
> > @@ -506,15 +506,7 @@ static bool ltdc_crtc_mode_fixup(struct drm_crtc *=
crtc,
> >                                struct drm_display_mode *adjusted_mode)
> >   {
> >       struct ltdc_device *ldev =3D crtc_to_ltdc(crtc);
> > -     struct drm_device *ddev =3D crtc->dev;
> >       int rate =3D mode->clock * 1000;
> > -     bool runtime_active;
> > -     int ret;
> > -
> > -     runtime_active =3D pm_runtime_active(ddev->dev);
> > -
> > -     if (runtime_active)
> > -             pm_runtime_put_sync(ddev->dev);
> >
> >       if (clk_set_rate(ldev->pixel_clk, rate) < 0) {
> >               DRM_ERROR("Cannot set rate (%dHz) for pixel clk\n", rate)=
;
> > @@ -523,14 +515,6 @@ static bool ltdc_crtc_mode_fixup(struct drm_crtc *=
crtc,
> >
> >       adjusted_mode->clock =3D clk_get_rate(ldev->pixel_clk) / 1000;
> >
> > -     if (runtime_active) {
> > -             ret =3D pm_runtime_get_sync(ddev->dev);
> > -             if (ret) {
> > -                     DRM_ERROR("Failed to fixup mode, cannot get sync\=
n");
> > -                     return false;
> > -             }
> > -     }
> > -
> >       DRM_DEBUG_DRIVER("requested clock %dkHz, adjusted clock %dkHz\n",
> >                        mode->clock, adjusted_mode->clock);
> >
> >
> Hi Yannick,
> Many thanks for your patch,
> Acked-by: Philippe Cornu <philippe.cornu@st.com>
> Philippe :-)

Applied on drm-misc-next.

Thanks,
Benjamin

> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel