Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp438507ybt; Wed, 8 Jul 2020 03:42:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxCZwcIPcNwr10MqY2LsjnPFW9tb4S+YCcPVLY+ppctHo28sQUF7Aj1kIFP5wP+FzbjoiRz X-Received: by 2002:a17:906:2b0e:: with SMTP id a14mr24405150ejg.459.1594204923561; Wed, 08 Jul 2020 03:42:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594204923; cv=none; d=google.com; s=arc-20160816; b=NKdLCDO+ImsZ7R9blWask6Nx+hNEMT1OOF47MW6pT4TVNeaxIXsDi2fRBZhxeozT2T r7U4ymmjCqBj65quJBrCUDNlM7wl/CyrS1ux866dsM2Y7YM1KENKHlYKSRQrFQ/sYGUI RTE8DVVPMI2EjyUzU1w/hx2AfkQ1hhP+vwTF8LYZOP0DxwD71xR/BpFJdFdt4k7w/Bw9 kYb+Re55I2lkFHbT6w005Jnf9e4fr5Mi2uSRfD2i8PmIYVsZenK+DFZ8kbf5xKZBc5oM 8muQ6cBQuyMF5uDJEldzCUtsgKfc3MAbDxMZHbZGNP09CY5zNvsXR/jO2z1gpzlgAFny 114g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=C+dKAY+NlI0eAzFr/eUv8dy/YrqzTracpUPjsPNLWj8=; b=Sg9o2EyID+SaxAGPkKgxquRyolW/pwz8vvVWskJvoB6d40pULpN3s93ANBPC7Fgord di2a+FuIgg3WJ1w0iHFZaeoQMQm7RK9+A+YlmLpx9H12Tthb42fW4fjge7MHC4yhd6a2 sGc6g8abAp6o4Yg10FOTyKRW+SptT5aXWArxgAiSY7MuCMatsL1YDn9Br9jIbfflJ8qz tCw4Qov/KxbhnEEtEVz+xZMqpBQTiFDcpKwuQnzpvMTNna00ebNxdq+ahhF3AD53CfcG Dh4qpSzkB9ek+EWSweOJxYbEnuyNBa1qRtnWFdS4z+p2kXRdJ/fuZRqsFZe1Yfll0iTi Sn4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LUVVW7UK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bh13si16369156ejb.48.2020.07.08.03.41.40; Wed, 08 Jul 2020 03:42:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LUVVW7UK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728454AbgGHKjd (ORCPT + 99 others); Wed, 8 Jul 2020 06:39:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:36870 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728104AbgGHKjc (ORCPT ); Wed, 8 Jul 2020 06:39:32 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D130D20739; Wed, 8 Jul 2020 10:39:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594204772; bh=VWPhC4Gq7pX7sjLhrLhoCa8iCMdRCFzbp0T4IOiWh8k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LUVVW7UKQebpZCxfAj/yfH0JqmWyqZimy2Nlld785FUp7uDteMXJs8RhnWUzwrCYH Nywyx1PO0sK2W/w981QVWvsVP8WdV7uzOMY8T2DfJKGS/89ejltpW0w5fFBhGdkUe3 uh0F/75gJB+K4sYTOj83VFq+UrIBtnOGi3cEnUPM= Date: Wed, 8 Jul 2020 12:39:28 +0200 From: Greg KH To: "Alexander A. Klimov" Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Replace HTTP links with HTTPS ones: USB MASS STORAGE DRIVER Message-ID: <20200708103928.GC585606@kroah.com> References: <20200708095500.13694-1-grandmaster@al2klimov.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200708095500.13694-1-grandmaster@al2klimov.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 08, 2020 at 11:55:00AM +0200, Alexander A. Klimov wrote: > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn't contain `\bxmlns\b`: > For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`: > If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`: > If both the HTTP and HTTPS versions > return 200 OK and serve the same content: > Replace HTTP with HTTPS. > > Signed-off-by: Alexander A. Klimov Your subject lines are very odd compared to all patches for this subsystem, as well as all other kernel subsystems. Any reason you are doing it this way and not the normal and standard method of: USB: storage: replace http links with https That would look more uniform as well as not shout at anyone. thanks, greg k-h