Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp549200ybt; Wed, 8 Jul 2020 06:18:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJww+h6L4cHixNzpsZWjIoz0R8W9cFqM347YdxkOhdEfFCy/75NPI7DfKe2jnvQ/CCFKLpor X-Received: by 2002:a05:6402:1a54:: with SMTP id bf20mr66333120edb.69.1594214329074; Wed, 08 Jul 2020 06:18:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594214329; cv=none; d=google.com; s=arc-20160816; b=yVzbNkR/NljqdstJ8b2CZ4b6KGaKIHLhWUJ2FfUD+9LxySdNSERGtHGb9DWrPGrQ4Z W6n9QLOQLMZ8ouUTauGZvt0ZGmqHoZ+lQwTfbwFJbgCA1xTt7Q41D0xg6X5obBq2suyj GRdhqNPUVGNRwlwVVf9JqV4nrVKDb39U6A5GGeleeAFXLdjNng/SkCrBdS4spGTfrFZf Vo9lgE65MWDNx/lO9FVyyNdlIVUOWfDdTHoT+7LSnqHcFsiowiUlaAoopXwxSe6m2Kc9 dkRNxH8/KHzyX1d7fmSw8IOkBOp1d5H0Redqibq0hsU5lqMhUn3+PCVie7x/oqNi5lQe wS2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=PWRsLjeSIRxFVm4lyVcX8i8BX8wAJXIoc5VxUkUZwHw=; b=JEx2mDbTYhs4J9s1m37tU+FYiqhD5ZPF4+EeVpshwUF4w2MlAADdbypIszXStmBL0n hxaZfJnZrGSZTC9hW2fUnTvat0Gq+LF4eVv0aAZpCUR5m7joOhmY/3rzhHHj1X8qoT/u TTlGQOTzMc3b5P8PoyBPyVut6OQR7BkYDW/d1oCuZf1jjcbxaPzjC3owqxQzPv3XteIe cHje18eGF2YCQszuCAJl2TDWipETEoifYQ9QXfYkmgAShJuaq9j5qTKx/+gMM7uWmyMV 2irbj0MqB7tlCKulGvdhgKNxaPzYRYtDl7lnUQb9TbOaBdY+k9oB9azHGCMB5aCUVmc7 7jaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cloud.ionos.com header.s=google header.b=NRmx+ioE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z9si16151838ejw.604.2020.07.08.06.18.25; Wed, 08 Jul 2020 06:18:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cloud.ionos.com header.s=google header.b=NRmx+ioE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729147AbgGHNRk (ORCPT + 99 others); Wed, 8 Jul 2020 09:17:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729202AbgGHNRj (ORCPT ); Wed, 8 Jul 2020 09:17:39 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BF04C08E763 for ; Wed, 8 Jul 2020 06:17:39 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id o18so46063635eje.7 for ; Wed, 08 Jul 2020 06:17:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.ionos.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=PWRsLjeSIRxFVm4lyVcX8i8BX8wAJXIoc5VxUkUZwHw=; b=NRmx+ioEz6/FYs1tzoxGi406btC1lF515cu2m+XhPpoZlDvLC8m4Rx6T02t1upk6NR U/YFLRrHV/9kv25tgJgmmU+kkk7cmuh9uB1y5Js51AfgxLzxY5x+eNIbEdT32C4Q/HLL l5EjfsqCgr4kUPL0bcbfmiompBtODUlVy++jzvY13da932wqsypwIexKAdETrFHtDeSj 8ZIPwD12o35KK35d9Tk9KZ59lTx7605Hr2TG81u9wbmlZogkmAEVlkoTBILQa4FbWk4n rgn+F9UIc2OpOgNDVudX27htma2p8jjwRp5zXUilqohiabSLqBIGwOoOQh9Jcn0xLoFU I0kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=PWRsLjeSIRxFVm4lyVcX8i8BX8wAJXIoc5VxUkUZwHw=; b=qDIfwZfmFw2sNvd/CG8HqDuFlxnhZrSggOQrYNz19WFvMfjXZnEmh+zJ2Li5nIlyd4 YeIhCK48nKkc9wHzRDqAEIaqBEt9qr6zQjNbbjNl+yKruAO5aM6R8NoOZp9jKZFRvwDL AZK5NFHi07YnoGGZNYkwJ1GddcRpXiLkMmzOMfu6zoYQvu/svueVrXgOaB/w/LvBMKRL biu+hWZJg5cZH9B3jXFsrE+QrkqTKiaXmGCfekOh9RCZ99/0WVwXuatHjwyk6ZJuZfYy 0bDIGjWs4rsPNbUbTuW8OHC+P1VoPiwkZNXcFSrcVxnJK+4uqrEkQqNLMsOI+LRxL4hf 4tmw== X-Gm-Message-State: AOAM531abWAXiYgHesTFG0KfcR6buNRDxd5NTeFXlyvT3kxdEPWmp96U XPMk8e9sqpCZTw23tfZCmTGZmA== X-Received: by 2002:a17:907:1051:: with SMTP id oy17mr53833820ejb.394.1594214258033; Wed, 08 Jul 2020 06:17:38 -0700 (PDT) Received: from [192.168.178.33] (i5C746C99.versanet.de. [92.116.108.153]) by smtp.gmail.com with ESMTPSA id v11sm1936527eja.113.2020.07.08.06.17.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jul 2020 06:17:37 -0700 (PDT) Subject: Re: [PATCH 1/6] md: switch to ->check_events for media change notifications To: Christoph Hellwig , Jens Axboe Cc: Song Liu , Ulf Hansson , linux-kernel@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-block@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20200708122546.214579-1-hch@lst.de> <20200708122546.214579-2-hch@lst.de> From: Guoqing Jiang Message-ID: <09cd4827-52ae-0e7c-c3d3-e9a6cd27ff2b@cloud.ionos.com> Date: Wed, 8 Jul 2020 15:17:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200708122546.214579-2-hch@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/8/20 2:25 PM, Christoph Hellwig wrote: > -static int md_media_changed(struct gendisk *disk) > -{ > - struct mddev *mddev = disk->private_data; > - > - return mddev->changed; > -} Maybe we can remove "changed" from struct mddev since no one reads it after the change. Thanks, Guoqing