Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp584500ybt; Wed, 8 Jul 2020 07:03:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxFTrYaVSRwOA8xmAR9ipPTC/aGplWJnV8BpyAq59lLU+qGR28bwBNudDBIbccwKfQ99w3 X-Received: by 2002:a17:906:2505:: with SMTP id i5mr50887402ejb.545.1594217033768; Wed, 08 Jul 2020 07:03:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594217033; cv=none; d=google.com; s=arc-20160816; b=Aqg6/hMt0nsLk0usKgkyepvt5V92laft2QNmERJT0aXWvXfKrMJXw+/x5muJQuD9pc MNFubjZPU6SrfThuv6OJ21VbSblGtli3bEodlM4DXiVdrZwXPbtWHE0FmQ56JeORcTM3 6f4TvE3HCjo1D8y6AhbayH3AzcS/wUQzfRGG5IeIO/Ig76lJF4bjnjxaxRjyoVYC/7uF lfms44IPZQjTSrnaXH7pqjjFLC7WFzX6LZ5q0PLGomL5mN+bjUhbIc4I7tKLzX+KBf4J k6rKLm9sNRBY8rysiko8KoiYeTxEaJjBkFVhXNGaPzdZtq6m5qs4lyuc3ioliGLIGJLU FdFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:to:from:subject:message-id; bh=8HsrP6KHLe7Wz6WP4npQIcTJGPWafPB5ODwGCvzF2+8=; b=WP8K32tWvNmS/cOdRrDYDd79LH9Q1WqChvsE7OH6FzYb9eLONyu3/v+UdzZLsORFP6 6qmT0l7KjIqimyJuy6oHJhJSqHZLMx0QVuKYyjIqAbwl+g7SG8Mbco+0vbJPH06g8vD1 enTD182UOybGNYEkeZMsN2y4E4OsJyByvop3og3FoaW9Yq653rn3gakh7uaTBmZ+4F6S xkrXxlNydiGcEyHcHDMOEyPXFrFSoZil2Rl+g6btsySVs4XvLulYr9/ZHTMteN6fXal7 rQmxOvcOgucNMg8ynqT3lpa1QVejs6HNXK9t/GUpqhV/GebQlGBDKTSRo1J+r8tjPfnq pntw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i6si16593776ejj.508.2020.07.08.07.03.28; Wed, 08 Jul 2020 07:03:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729845AbgGHOBl (ORCPT + 99 others); Wed, 8 Jul 2020 10:01:41 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:61480 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729469AbgGHOBl (ORCPT ); Wed, 8 Jul 2020 10:01:41 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 068E1XME062333; Wed, 8 Jul 2020 10:01:37 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 325d2cde6e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Jul 2020 10:01:37 -0400 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 068E1atN062590; Wed, 8 Jul 2020 10:01:36 -0400 Received: from ppma04fra.de.ibm.com (6a.4a.5195.ip4.static.sl-reverse.com [149.81.74.106]) by mx0b-001b2d01.pphosted.com with ESMTP id 325d2cddx2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Jul 2020 10:01:36 -0400 Received: from pps.filterd (ppma04fra.de.ibm.com [127.0.0.1]) by ppma04fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 068E1IDR021113; Wed, 8 Jul 2020 14:01:18 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma04fra.de.ibm.com with ESMTP id 3251dw0d06-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Jul 2020 14:01:18 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 068E1GtW9503062 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 8 Jul 2020 14:01:16 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 084A5AE05D; Wed, 8 Jul 2020 14:01:16 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5D07AAE053; Wed, 8 Jul 2020 14:01:15 +0000 (GMT) Received: from localhost.localdomain (unknown [9.80.202.84]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 8 Jul 2020 14:01:15 +0000 (GMT) Message-ID: <1594216873.23056.211.camel@linux.ibm.com> Subject: Re: [PATCH ima-evm-utils 1/3] ima-evm-utils: Fix mismatched type checking From: Mimi Zohar To: Tianjia Zhang , vt@altlinux.org, linux-kernel@vger.kernel.org Date: Wed, 08 Jul 2020 10:01:13 -0400 In-Reply-To: <20200707033548.21640-1-tianjia.zhang@linux.alibaba.com> References: <20200707033548.21640-1-tianjia.zhang@linux.alibaba.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-07-08_11:2020-07-08,2020-07-08 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 lowpriorityscore=0 mlxscore=0 clxscore=1015 impostorscore=0 spamscore=0 suspectscore=0 cotscore=-2147483648 adultscore=0 mlxlogscore=999 bulkscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2007080099 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-07-07 at 11:35 +0800, Tianjia Zhang wrote: > Even if imaevm_get_hash_algo() returns an error value of -1, it is > forced to be converted to uint8_t type here, resulting in this error > not being checked by the if condition. This patch fixes this error. > > Signed-off-by: Tianjia Zhang Thanks!  This patch is now queued in the next branch. Mimi