Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Pawel Laszczak <pawell@cadence.com>
To:     Peter Chen <peter.chen@nxp.com>
CC:     "balbi@kernel.org" <balbi@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "rogerq@ti.com" <rogerq@ti.com>,
        "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
        "heikki.krogerus@linux.intel.com" <heikki.krogerus@linux.intel.com>,
        "colin.king@canonical.com" <colin.king@canonical.com>,
        Jayshri Dajiram Pawar <jpawar@cadence.com>,
        "ben.dooks@codethink.co.uk" <ben.dooks@codethink.co.uk>,
        Rahul Kumar <kurahul@cadence.com>,
        Sanket Parmar <sparmar@cadence.com>
Subject: RE: [PATCH 2/9] usb: cdns3: Improvement: removed not needed variables
 initialization
Thread-Topic: [PATCH 2/9] usb: cdns3: Improvement: removed not needed
 variables initialization
Thread-Index: AQHWT3AXbR9NJZf3Uk+pPHARL3MaNqj7r2UAgAIUBWA=
Date:   Wed, 8 Jul 2020 14:18:56 +0000
Message-ID: <DM6PR07MB552924C997407B3567A5C1E5DD670@DM6PR07MB5529.namprd07.prod.outlook.com>
References: <20200701062004.29908-1-pawell@cadence.com>
 <20200701062004.29908-3-pawell@cadence.com>
 <20200707062341.GC16073@b29397-desktop>
In-Reply-To: <20200707062341.GC16073@b29397-desktop>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b2246cd-582c-4776-b89e-08d82349d9ce
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2020 14:18:56.4854
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SkBvwZuMLm9A922nB0hr6q/1aRu2JsrIX7hzoHulaASlNapkqhaqnkoP+ESvkiLajnAXkZpD0C8HhUriMz9NgPOW/zNXeAqWiVR4ikpaorE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB5675
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687
 definitions=2020-07-08_13:2020-07-08,2020-07-08 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 phishscore=0
 clxscore=1015 adultscore=0 suspectscore=0 mlxscore=0 cotscore=-2147483648
 priorityscore=1501 mlxlogscore=753 lowpriorityscore=0 malwarescore=0
 spamscore=0 bulkscore=0 impostorscore=0 classifier=spam adjust=0
 reason=mlx scancount=1 engine=8.12.0-2004280000
 definitions=main-2007080102
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>
>
>On 20-07-01 08:19:57, Pawel Laszczak wrote:
>> Patch remove some variables initialization from core.c and drd.c
>> file.
>>
>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>> ---
>>  drivers/usb/cdns3/core.c |  4 ++--
>>  drivers/usb/cdns3/drd.c  | 19 +++++++++----------
>>  2 files changed, 11 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c
>> index eaafa6bd2a50..c3dac945f63d 100644
>> --- a/drivers/usb/cdns3/core.c
>> +++ b/drivers/usb/cdns3/core.c
>> @@ -86,7 +86,7 @@ static int cdns3_core_init_role(struct cdns3 *cdns)
>>  	struct device *dev =3D cdns->dev;
>>  	enum usb_dr_mode best_dr_mode;
>>  	enum usb_dr_mode dr_mode;
>> -	int ret =3D 0;
>> +	int ret;
>>
>>  	dr_mode =3D usb_get_dr_mode(dev);
>>  	cdns->role =3D USB_ROLE_NONE;
>> @@ -177,7 +177,7 @@ static int cdns3_core_init_role(struct cdns3 *cdns)
>>  		goto err;
>>  	}
>>
>> -	return ret;
>> +	return 0;
>>  err:
>>  	cdns3_exit_roles(cdns);
>>  	return ret;
>> diff --git a/drivers/usb/cdns3/drd.c b/drivers/usb/cdns3/drd.c
>> index 58089841ed52..4939a568d8a2 100644
>> --- a/drivers/usb/cdns3/drd.c
>> +++ b/drivers/usb/cdns3/drd.c
>> @@ -29,7 +29,6 @@
>>   */
>>  int cdns3_set_mode(struct cdns3 *cdns, enum usb_dr_mode mode)
>>  {
>> -	int ret =3D 0;
>>  	u32 reg;
>>
>>  	switch (mode) {
>> @@ -61,7 +60,7 @@ int cdns3_set_mode(struct cdns3 *cdns, enum usb_dr_mod=
e mode)
>>  		return -EINVAL;
>>  	}
>>
>> -	return ret;
>> +	return 0;
>>  }
>>
>>  int cdns3_get_id(struct cdns3 *cdns)
>> @@ -134,11 +133,11 @@ static void cdns3_otg_enable_irq(struct cdns3 *cdn=
s)
>>  int cdns3_drd_switch_host(struct cdns3 *cdns, int on)
>>  {
>>  	int ret, val;
>> -	u32 reg =3D OTGCMD_OTG_DIS;
>>
>>  	/* switch OTG core */
>>  	if (on) {
>> -		writel(OTGCMD_HOST_BUS_REQ | reg, &cdns->otg_regs->cmd);
>> +		writel(OTGCMD_HOST_BUS_REQ | OTGCMD_OTG_DIS,
>> +		       &cdns->otg_regs->cmd);
>>
>>  		dev_dbg(cdns->dev, "Waiting till Host mode is turned on\n");
>>  		ret =3D readl_poll_timeout_atomic(&cdns->otg_regs->sts, val,
>> @@ -212,7 +211,7 @@ int cdns3_drd_switch_gadget(struct cdns3 *cdns, int =
on)
>>   */
>>  static int cdns3_init_otg_mode(struct cdns3 *cdns)
>>  {
>> -	int ret =3D 0;
>> +	int ret;
>>
>>  	cdns3_otg_disable_irq(cdns);
>>  	/* clear all interrupts */
>> @@ -223,7 +222,8 @@ static int cdns3_init_otg_mode(struct cdns3 *cdns)
>>  		return ret;
>>
>>  	cdns3_otg_enable_irq(cdns);
>> -	return ret;
>> +
>> +	return 0;
>>  }
>>
>>  /**
>> @@ -234,7 +234,7 @@ static int cdns3_init_otg_mode(struct cdns3 *cdns)
>>   */
>>  int cdns3_drd_update_mode(struct cdns3 *cdns)
>>  {
>> -	int ret =3D 0;
>> +	int ret;
>>
>>  	switch (cdns->dr_mode) {
>>  	case USB_DR_MODE_PERIPHERAL:
>> @@ -307,8 +307,8 @@ static irqreturn_t cdns3_drd_irq(int irq, void *data=
)
>>  int cdns3_drd_init(struct cdns3 *cdns)
>>  {
>>  	void __iomem *regs;
>> -	int ret =3D 0;
>>  	u32 state;
>> +	int ret;
>>
>>  	regs =3D devm_ioremap_resource(cdns->dev, &cdns->otg_res);
>>  	if (IS_ERR(regs))
>> @@ -359,7 +359,6 @@ int cdns3_drd_init(struct cdns3 *cdns)
>>  					cdns3_drd_thread_irq,
>>  					IRQF_SHARED,
>>  					dev_name(cdns->dev), cdns);
>> -
>>  	if (ret) {
>>  		dev_err(cdns->dev, "couldn't get otg_irq\n");
>>  		return ret;
>> @@ -371,7 +370,7 @@ int cdns3_drd_init(struct cdns3 *cdns)
>>  		return -ENODEV;
>>  	}
>>
>> -	return ret;
>> +	return 0;
>
>Is this necessary?

It's not necessary, its only improvement suggested by Dan Carpenter
during reviewing the other CDNSP driver.
It improves readability of code because we don't need analyze what is=20
in ret variable.=20

--
Regards,
Pawel