Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 8 Jul 2020 16:25:26 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     "Ahmed S. Darwish" <a.darwish@linutronix.de>
Cc:     Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Paul E. McKenney" <paulmck@kernel.org>,
        "Sebastian A. Siewior" <bigeasy@linutronix.de>,
        Steven Rostedt <rostedt@goodmis.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 06/20] seqlock: Extend seqcount API with associated
 locks
Message-ID: <20200708142526.GR117543@hirez.programming.kicks-ass.net>
References: <20200630054452.3675847-1-a.darwish@linutronix.de>
 <20200630054452.3675847-7-a.darwish@linutronix.de>
 <20200706212148.GE5523@worktop.programming.kicks-ass.net>
 <20200707084024.GA4097637@debian-buster-darwi.lab.linutronix.de>
 <20200707130410.GO4800@hirez.programming.kicks-ass.net>
 <20200707143726.GO117543@hirez.programming.kicks-ass.net>
 <20200708103314.GB4151780@debian-buster-darwi.lab.linutronix.de>
 <20200708122938.GQ4800@hirez.programming.kicks-ass.net>
 <20200708141332.GQ117543@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200708141332.GQ117543@hirez.programming.kicks-ass.net>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jul 08, 2020 at 04:13:32PM +0200, Peter Zijlstra wrote:
> On Wed, Jul 08, 2020 at 02:29:38PM +0200, Peter Zijlstra wrote:
> 
> > #define SEQCOUNT_LOCKTYPE(name, locktype, preempt, lockmember)		\
> > typedef struct seqcount_##name {					\
> > 	seqcount_t	seqcount;					\
> > 	__SEQCOUNT_LOCKDEP(locktype *lock);				\
> > } seqcount_##name##_t;							\
> > 									\
> > static __always_inline void						\
> > seqcount_##name##_init(seqcount_##name##_t *s, locktype *l)		\
> > {									\
> > 	seqcount_init(&s->seqcount);					\
> > 	__SEQCOUNT_LOCKDEP(s->lock = l);				\
> > }									\
> > 									\
> > static __always_inline __seqprop_ptr_t					\
> > __seqprop_##name##_ptr(seqcount_##name##_t *s)				\
> > {									\
> > 	return &s->seqcount;						\
> > }									\
> > 									\
> > static __always_inline __seqprop_preempt_t				\
> > __seqprop_##name##_preempt(seqcount_##name##_t *s)			\
> > {									\
> > 	return preempt;							\
> > }									\
> > 									\
> > static __always_inline __seqprop_assert_t				\
> > __seqprop_##name##_assert(seqcount_##name##_t *s)			\
> > {									\
> > 	__SEQCOUNT_LOCKDEP(lockdep_assert_held(s->lockmember));		\
> > }
> 
> For PREEMPT_RT's magic thing, you can add:
> 
> static __always_inline void						\
> __seqprop_##name##_lock(seqcount_##name##_t *s)				\
> {									\
> 	if (!__SEQ_RT || !preempt)					\
> 		return;							\
> 									\
> 	lockbase##_lock(&s->lock);					\
> 	lockbase##_unlock(&s->lock);					\
> }
> 
> and:
> 
> #define __rt_lock_unlock_associated_sleeping_lock(s) __seqprop(s, lock)

Or possible have it like:

	if (!__SEQ_RT || !preempt)
		return smp_cond_load_relaxed(&s->seqcount->sequence, !(VAL & 1));

	lockbase##_lock(&s->lock);
	lockbase##_unlock(&s->lock);

	return READ_ONCE(s->seqcount->sequence);

and then replace most of __read_seqcount_begin() with it.