Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp649164ybt; Wed, 8 Jul 2020 08:25:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFXu7NGUAjQP1zah0+71avbOXMMZLHDnmP9ieyi2lh6fTynG/+LfJXnnXPVZ12uGTcWFEn X-Received: by 2002:a05:6402:134e:: with SMTP id y14mr68036348edw.4.1594221949279; Wed, 08 Jul 2020 08:25:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594221949; cv=none; d=google.com; s=arc-20160816; b=ZxFo1UdI+B2jtPd88rFR+HFYbFvkriTZ2npgBh8pRinaIbq3ntg+FLxqTB2gqC/Wg1 K7zb2xXdPmtF6u+DYBoRz81FunkcFo1+2m8YQoZlOoIWXXxlcmiQNwJ8xnxNZEhxop2Z IzcZviCHpvNDqQBJJu+GhB0tJg27iqV7TYGtQr25O8Pfk5Oin3LXRikpoXDlbhXNdUne 0UjGvJntzUHBKMoC3GRDSRVgJs0oZFdSoCXnJLwacuRm507qin1hQFmXEy9WloIcpzoB kgVUoo1XqI6tB1mC4rrVFDeo2zu8gKV6ZXPJdi0TRBQbrGOJjIz371q9My/Wlzb9e7Tt u+xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=KO628LRg0KELEzDGxGBW/eAFQb7hOqQ53yrytEwvgvY=; b=dEaTcy/Tl4FPMddESBW/DyIz+va2MeBjDHIgxdVCP2YJXck4vOgiMrWAkO7e5BGF0h NoTvB67t2bMnPVd/f5uoyCc72lQq4TCCC5McZIgeZt0sYtqFSWFJxSNbEkPGZiq0RYW7 vLOUA/oyGvoA5+jTTonJ6tP6TysjyoUbxUVRj8eCtGD86N5OD0ZRye+1Uyv6eZH7C2I8 rLPX3J3RoGrz3D6//ox+9tG3WqVQaa0Fp2vlslGzf/64qQJENL35VISpCw0mv12ZZB8T r3XUz48RcvqH7nwzStHK4SzYuLP9BeOOflcAXFQmheb0KENEkzxcQ9gXLE4OOJQVdR1x xsmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=hi5oTWy7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t22si105466edr.571.2020.07.08.08.25.26; Wed, 08 Jul 2020 08:25:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=hi5oTWy7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730028AbgGHPWT (ORCPT + 99 others); Wed, 8 Jul 2020 11:22:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729848AbgGHPWT (ORCPT ); Wed, 8 Jul 2020 11:22:19 -0400 Received: from mail-ua1-x941.google.com (mail-ua1-x941.google.com [IPv6:2607:f8b0:4864:20::941]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55BA3C061A0B for ; Wed, 8 Jul 2020 08:22:19 -0700 (PDT) Received: by mail-ua1-x941.google.com with SMTP id l12so9745191uak.7 for ; Wed, 08 Jul 2020 08:22:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KO628LRg0KELEzDGxGBW/eAFQb7hOqQ53yrytEwvgvY=; b=hi5oTWy7PCy7YqHRotH3tuH/k2HpctPr7tYVQrxyXCdwfKApDHb6zk8Hv57vOZr7+T uPq3gVmSKLp0lfFLbDvVPJM0L70JoAwZ4cie7WIwJNK8QhE26q9c5evYUjyZgyWdScU1 mb2a+uTp0kfIJg7L3WdoAHaG/3DhMm2oR+B2Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KO628LRg0KELEzDGxGBW/eAFQb7hOqQ53yrytEwvgvY=; b=Zma1Hu5PJPoU3UDt51qLQkw0DIYKpXOnlU/3maQHaH6Rdfguhi31tM5MyeX32kPKOe TrJmtI4Be7r5b9WI1IN54TtRO62M0vBB45nBUdOfZIB993oeTpjmDae8QSnfyikHrWxX drqeBT0FkWMfFWbPHoAUyWM8FLVCZUIYTZ8NIo6z2jfFhkg8KHuOjiaj2nCBpR2hCdZ9 6jwug5m1qYFt1DKWENQzz+t+1ETYpb/dAWOunNHJ86NYmykdduEFaqw581R5B4+1HTNF mSglwf/sAHzpx23rPBvCXYazh+X5DP1oQXzMQ6ns572tZAxv4Kyc5cMQuCSpih0pOghh 7sxw== X-Gm-Message-State: AOAM533kOdX7VxiCZ6Y+Vami3eihl1Qzh4A30DRkRh2hhluV8/cvQbff TVN3hBeiVimvDxuI5JzPpSUF2CzHzrE= X-Received: by 2002:ab0:6353:: with SMTP id f19mr33360279uap.69.1594221738354; Wed, 08 Jul 2020 08:22:18 -0700 (PDT) Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com. [209.85.222.43]) by smtp.gmail.com with ESMTPSA id h10sm18242uah.19.2020.07.08.08.22.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jul 2020 08:22:17 -0700 (PDT) Received: by mail-ua1-f43.google.com with SMTP id h18so8467027uao.6 for ; Wed, 08 Jul 2020 08:22:17 -0700 (PDT) X-Received: by 2002:ab0:2408:: with SMTP id f8mr34039056uan.91.1594221736757; Wed, 08 Jul 2020 08:22:16 -0700 (PDT) MIME-Version: 1.0 References: <20200702004509.2333554-1-dianders@chromium.org> <20200701174506.1.Icfdcee14649fc0a6c38e87477b28523d4e60bab3@changeid> <20200707120812.GA22129@sirena.org.uk> <20200708100110.GB4655@sirena.org.uk> In-Reply-To: <20200708100110.GB4655@sirena.org.uk> From: Doug Anderson Date: Wed, 8 Jul 2020 08:22:05 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] spi: spi-geni-qcom: Avoid clock setting if not needed To: Mark Brown Cc: Andy Gross , Bjorn Andersson , Akash Asthana , linux-arm-msm , Maulik Shah , Stephen Boyd , Georgi Djakov , ctheegal@codeaurora.org, Matthias Kaehlcke , LKML , linux-spi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, Jul 8, 2020 at 3:01 AM Mark Brown wrote: > > On Tue, Jul 07, 2020 at 05:53:01AM -0700, Doug Anderson wrote: > > On Tue, Jul 7, 2020 at 5:08 AM Mark Brown wrote: > > > > This doesn't apply against current code, please check and resend. > > > As mentioned in the cover letter, I posted this series against the > > Qualcomm tree. The commit that it is fixing landed there with your > > Ack so I was hoping this series could land in the Qualcomm tree with > > your Ack as well. Would that be OK? > > So I didn't see this until after the patch I applied was queued... it's > looking like it would be good to have a cross-tree merge with the > Qualcomm tree if there's stuff like this - is this on a branch which > makes that practical? Otherwise I guess... It's not too bad. Of the 5 patches I've sent out (3 for geni SPI, 2 for quad SPI) you've landed just one. Here's the summary: a) geni SPI 1/3 (Avoid clock setting): Has your Ack. b) geni SPI 2/3 (autosuspend delay): Landed in SPI tree c) geni SPI 3/3 (overhead in prepare_message): Has your Ack. d) quad SPI 1/2 (Avoid clock setting): Needs your Ack. e) quad SPI 2/2 (autosuspend delay): Needs your Ack. Since b) has already landed in your tree, let's just leave it there. There'll be a bit of a performance hit in the Qualcomm tree, but it'll still be usable. Since the rest haven't landed, it would be nice to just land them in the Qualcomm tree. I think there's still more work to make the Geni SPI driver more optimized, but I don't think it'll be as urgent as those patches and I feel like any more major work could wait a cycle. -Doug