Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 8 Jul 2020 17:40:28 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     "Mukesh, Savaliya" <msavaliy@codeaurora.org>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Akash Asthana <akashast@codeaurora.org>, saravanak@google.com,
        sspatil@google.com, tkjos@google.com,
        linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V6] serial: msm_geni_serial_console : Add Earlycon support
Message-ID: <20200708154028.GC715257@kroah.com>
References: <1592820512-1225-1-git-send-email-akashast@codeaurora.org>
 <20200623194936.GE128451@builder.lan>
 <c2752c91-b203-4224-9ddf-1e5a03b6488b@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c2752c91-b203-4224-9ddf-1e5a03b6488b@codeaurora.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jul 08, 2020 at 08:06:52PM +0530, Mukesh, Savaliya wrote:
> 
> On 6/24/2020 1:19 AM, Bjorn Andersson wrote:
> > On Mon 22 Jun 03:08 PDT 2020, Akash Asthana wrote:
> > 
> > > From: Mukesh Kumar Savaliya <msavaliy@codeaurora.org>
> > > 
> > > This change enables earlyconsole support as static driver for geni
> > > based UART. Kernel space UART console driver will be generic for
> > > console and other usecases of UART.
> > > 
> > Is this hardware different from the qcom,geni-debug-uart which we
> > already have EARLYCON support for?
> > 
> > Why is this a separate driver?
> 
> The Hardware is same, but for the Generic kernel image we are using
> downstream driver which can't be a static compiled driver.

Why not?  Why not fix that?

> The same driver file has? 1.earlyconsole, 2.kernel console and 3.HSUART
> driver parts.
> 
> To make Generic image, 2 and 3 are internal downstream driver and 1st one i
> am trying to get upstreamed, so that can be pulled into the ACK.

That has nothing to do with us, please do it correctly so that everyone
benifits.

> The one with the qcom,genu-debug-uart is not being used for our products.

So we can just delete it from the tree?

thanks,

greg k-h