Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp666237ybt; Wed, 8 Jul 2020 08:48:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzkcTVELBixD5+rwNsjI595D/EN2IrAZEYV0l8ysg+HjBknz6bQ9++91WQAZMt5B13vxCo8 X-Received: by 2002:a50:8d5a:: with SMTP id t26mr71274107edt.282.1594223310845; Wed, 08 Jul 2020 08:48:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594223310; cv=none; d=google.com; s=arc-20160816; b=HtwPwHcoSbJrUETeaBYl9QPbq4AfAenm7K2Xkoio9YLFB0rkB5NTOA+C9A0JPoSsrm SJga1huBPgZczeIv7Kmf2NFo8lueFt8GHSDtUN5+xnA/nyiXBnE83csfayivP58iZQv5 VdeVpKM/YPZqoDsD88mEfPZClz4DBkipJlmDJdPGa4zQjP9DoguzG80NAvtUzqE2GcHS zxaNkIaLxaKcRhGhmumFzJR0MAhW8ywoioQU+P22IUlJbK9rN8PbprSmYQvB8SW/7vkN spgnoIC8/MncNhCR5PhC5yQAZNUrTF9F/815seKU+E4xBg7NFQ4YfYLvpcA5zZ6tXn+u Btfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=mjthBLIsz4liv6A0P+AqTZP4C8ZYTcD/qNIx/0gL1YM=; b=Gnw1GkP8LFL5mUmfPeX/26d3tCZS9DY0SI/sNBsHNDfN0bQ1sFlOwyuSO2ymzZ7TBp 6NgGFOO/ukCLeAoBpz5mI7UVXn9wuyKw0gZ7PYfnoaygD3bXpQAMu3YIqiYCDlYTVB4/ vO9qrEX6c8WnTndgoD33GPrPB6p08cJoAFkqVf4LKe087+W+LECDV14//aDXz+9SRM2C hBq88jVPXYS2ntHlX+6mdRc0IlwOK4c1NrluUx/gXvSVPAM8c4z5e5Hth+ZvszyhaLDd 5quzWIF9FBG38HisYXq3vDSTuMdNPMcvCL9gODGDYrDDfnPA7P4YskeXK5HCedkagtaU nOeg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t12si108273ejr.551.2020.07.08.08.48.07; Wed, 08 Jul 2020 08:48:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730325AbgGHPpW (ORCPT + 99 others); Wed, 8 Jul 2020 11:45:22 -0400 Received: from mga09.intel.com ([134.134.136.24]:42581 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730238AbgGHPpW (ORCPT ); Wed, 8 Jul 2020 11:45:22 -0400 IronPort-SDR: WCZWhubuDuW7BI2dw21HWvLUkP7qBSvDm2vUvvcuFonKlhivTzqHlwuOgKo878p5O2Mz79ReUt EUAh5uSJUl6g== X-IronPort-AV: E=McAfee;i="6000,8403,9676"; a="149337381" X-IronPort-AV: E=Sophos;i="5.75,327,1589266800"; d="scan'208";a="149337381" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2020 08:45:21 -0700 IronPort-SDR: vVJ+YMfwq3ur0VH8KzSE1sOfEtddPujVDIpc+ye2YEpKOlrzq7OuFIlkc/HJicq4D1FZ9JK1eZ NgdERwSKHSwA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,327,1589266800"; d="scan'208";a="388853900" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.152]) by fmsmga001.fm.intel.com with ESMTP; 08 Jul 2020 08:45:20 -0700 Date: Wed, 8 Jul 2020 08:45:20 -0700 From: Sean Christopherson To: Paolo Bonzini Cc: Like Xu , kvm@vger.kernel.org, Wanpeng Li , Jim Mattson , Vitaly Kuznetsov , Joerg Roedel , linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM/x86: pmu: Fix #GP condition check for RDPMC emulation Message-ID: <20200708154520.GB22737@linux.intel.com> References: <20200708074409.39028-1-like.xu@linux.intel.com> <20200708151824.GA22737@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 08, 2020 at 05:31:14PM +0200, Paolo Bonzini wrote: > The order follows the SDM. I'm tempted to remove the CR0 check > altogether, since non-protected-mode always runs at CPL0 AFAIK, but let's > keep it close to what the manual says. Heh, it wouldn't surprise me in the least if there's a way to get the SS arbyte to hold a non-zero DPL in real mode :-).