Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <1594225718.23056.257.camel@linux.ibm.com>
Subject: Re: [PATCH ima-evm-utils 2/3] ima-evm-utils: beautify the code to
 make it more readable
From:   Mimi Zohar <zohar@linux.ibm.com>
To:     Tianjia Zhang <tianjia.zhang@linux.alibaba.com>, vt@altlinux.org,
        linux-kernel@vger.kernel.org
Date:   Wed, 08 Jul 2020 12:28:38 -0400
In-Reply-To: <20200707033548.21640-2-tianjia.zhang@linux.alibaba.com>
References: <20200707033548.21640-1-tianjia.zhang@linux.alibaba.com>
         <20200707033548.21640-2-tianjia.zhang@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 2020-07-07 at 11:35 +0800, Tianjia Zhang wrote:
> @@ -625,7 +625,7 @@ int ima_verify_signature(const char *file, unsigned char *sig, int siglen,
>  	unsigned char hash[MAX_DIGEST_SIZE];
>  	int hashlen, sig_hash_algo;
>  
> -	if (sig[0] != 0x03) {
> +	if (sig[0] != EVM_IMA_XATTR_DIGSIG) {
>  		log_err("xattr ima has no signature\n");
>  		return -1;
>  	}

This last hunk didn't apply properly.  The error message now includes
the filename.  I've fixed this patch.  In the future, please post
patches against the next-testing branch.

thanks,

Mimi