Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CAFXsbZrFRH2=+OgBARRkku2O0Okv=jg-uZaN+1Cv1tEwq-8k5Q@mail.gmail.com>
In-Reply-To: <CAFXsbZrFRH2=+OgBARRkku2O0Okv=jg-uZaN+1Cv1tEwq-8k5Q@mail.gmail.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Wed, 8 Jul 2020 15:40:54 -0300
Message-ID: <CAOMZO5C42kbRM7T3kphdOFZPCPHz6kS+32X3CPncrAnhiP3HFw@mail.gmail.com>
Subject: Re: [PATCH] ARM: dts: vf610-zii-dev-rev-c.dts: Configure fibre port
 to 1000BaseX
To:     Chris Healy <cphealy@gmail.com>
Cc:     Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Stefan Agner <stefan@agner.ch>,
        Rob Herring <robh+dt@kernel.org>,
        linux ARM <linux-arm-kernel@lists.infradead.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Chris,

In the Subject you could remove the .dts from the dts name:

ARM: dts: vf610-zii-dev-rev-c: Configure fibre port to 1000BaseX

On Sun, Jul 5, 2020 at 9:51 PM Chris Healy <cphealy@gmail.com> wrote:
>
> The SFF soldered onto the board expects the port to use 1000BaseX.  It
> makes no sense to have the port set to SGMII, since it doesn't even
> support that mode.
>
> Signed-off-by: Chris Healy <cphealy@gmail.com>
> ---
>  arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> index 778e02c000d1..de79dcfd32e6 100644
> --- a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> @@ -164,7 +164,7 @@
>                      port@9 {
>                          reg = <9>;
>                          label = "sff2";
> -                        phy-mode = "sgmii";
> +                        phy-mode = "1000base-x";

Looks like tabs were converted to spaces.