Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200618222620.5069-1-luc.vanoostenryck@gmail.com>
In-Reply-To: <20200618222620.5069-1-luc.vanoostenryck@gmail.com>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Wed, 8 Jul 2020 12:02:17 -0700
Message-ID: <CAHk-=wgRDFAkN-KNpVWUbf=1RUGn3=nMx6aZ7z2X9OhH5db-Og@mail.gmail.com>
Subject: Re: [PATCH] sparse: use the _Generic() version of __unqual_scalar_typeof()
To:     Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Marco Elver <elver@google.com>, Borislav Petkov <bp@suse.de>,
        Will Deacon <will@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jun 18, 2020 at 3:26 PM Luc Van Oostenryck
<luc.vanoostenryck@gmail.com> wrote:
>
> If the file is being checked with sparse, use the version of
> __unqual_scalar_typeof() using _Generic(), leaving the unoptimized
> version only for the oldest versions of GCC.

Side note: for unrelated reasons I decided to try to just raise the
gcc minimum to 4.9, which then makes this patch redundant. The old
non-_Generic() case simply doesn't exist any more.

Of course, maybe somebody screams about having to use some gcc-4.8
version in their environment so much that I'll revert it, but I doubt
it. gcc-4.8 had lots of problems.

                Linus