Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 8 Jul 2020 15:51:40 -0400
From:   Daniel Jordan <daniel.m.jordan@oracle.com>
To:     Nico Pache <npache@redhat.com>
Cc:     linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
        steffen.klassert@secunet.com, daniel.m.jordan@oracle.com
Subject: Re: [PATCH v2] Remove __init from padata_do_multithreaded and
 padata_mt_helper.
Message-ID: <20200708195140.hioiltf7pwppz6j7@ca-dmjordan1.us.oracle.com>
References: <20200702155548.14690-1-npache@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200702155548.14690-1-npache@redhat.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

(I was away for a while)

On Thu, Jul 02, 2020 at 11:55:48AM -0400, Nico Pache wrote:
> Allow padata_do_multithreaded function to be called after bootstrap.

The functions are __init because they're currently only needed during boot, and
using __init allows the text to be freed once it's over, saving some memory.

So this change, in isolation, doesn't make sense.  If there were an enhancement
you were thinking of making, this patch could then be bundled with it so the
change is made only when it's used.

However, there's still work that needs to be merged before
padata_do_multithreaded can be called after boot.  See the parts about priority
adjustments (MAX_NICE/renicing) and concurrency limits in this branch

  https://oss.oracle.com/git/gitweb.cgi?p=linux-dmjordan.git;a=shortlog;h=refs/heads/padata-mt-wip-v0.5

and the ktask discussions from linux-mm/lkml where concerns about these issues
were raised.  I plan to post these parts fairly soon and can include you if you
want.