Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 8 Jul 2020 14:49:00 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     "Ooi, Joyce" <joyce.ooi@intel.com>
Cc:     Thor Thayer <thor.thayer@linux.intel.com>,
        "David S . Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Dalon Westergreen <dalon.westergreen@linux.intel.com>,
        Tan Ley Foon <ley.foon.tan@intel.com>,
        See Chin Liang <chin.liang.see@intel.com>,
        Dinh Nguyen <dinh.nguyen@intel.com>,
        Dalon Westergreen <dalon.westergreen@intel.com>
Subject: Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher
Message-ID: <20200708144900.058a8b25@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20200708072401.169150-10-joyce.ooi@intel.com>
References: <20200708072401.169150-1-joyce.ooi@intel.com>
        <20200708072401.169150-10-joyce.ooi@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed,  8 Jul 2020 15:24:00 +0800 Ooi, Joyce wrote:
> +		/* get prefetcher rx poll frequency from device tree */
> +		if (of_property_read_u32(pdev->dev.of_node, "rx-poll-freq",
> +					 &priv->rx_poll_freq)) {
> +			dev_info(&pdev->dev, "Defaulting RX Poll Frequency to 128\n");
> +			priv->rx_poll_freq = 128;
> +		}
> +
> +		/* get prefetcher rx poll frequency from device tree */
> +		if (of_property_read_u32(pdev->dev.of_node, "tx-poll-freq",
> +					 &priv->tx_poll_freq)) {
> +			dev_info(&pdev->dev, "Defaulting TX Poll Frequency to 128\n");
> +			priv->tx_poll_freq = 128;
> +		}

I'm no device tree expert but these look like config options rather than
HW description. They also don't appear to be documented in the next
patch.