Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp947414ybt; Wed, 8 Jul 2020 16:10:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxGGelaxTdposw7YVtnAT7PoFcH3nm8w6xs4Uu5OhB5IwYOpVq4X4c0O3rvIR0vlcmj4xRv X-Received: by 2002:a17:906:328d:: with SMTP id 13mr54708787ejw.71.1594249802813; Wed, 08 Jul 2020 16:10:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594249802; cv=none; d=google.com; s=arc-20160816; b=1LPEX/lbMo9R+uiz340eLEU1TWGRiWlUY2kPLSzJKzOttqhhUXoI+CSUHDVdKQnWCj 2xCyjt8CGXOcaIFg3Ozm65wUg50A7qD078azD/e7fWW9z42Q8mu6fczxJ1jf+5g8kl06 fGXe6XeWc9sQZOi+UbTJ5FtQXFds/u0mXnu0YOAxzAKTysPv+TYtJePuM2TH/QwM7bVQ q3g9zmOzs+o/7HMhZI6oEi8k1DXlFQ075leV9tfaryD0EzruyK1joLa5KbljQA/nZohM DA0sD0y18iF3YIBdD2IiKAksZp6Dce9z1f9Potv0PXnP1vo+eKYFtLOurB+yj1bvXdBj ySbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=K62AiwFb4q0yaXMJV01ep0/eqa7Y40bBD3KscN2Jdj8=; b=z24kASuo1PnVK7NOpNsiTNiJtbNqa7ddGrr81FFdttCMZtfrD7tfKrM+3hm8457KT8 8NmF4Xt/fVxTsSgTnWDgcexkSQLqQz9/Wmx+JMfO7YWzUHIDcz8nQBz5BJ417cQFzBEi 5ClLUsge+xrNK77a0/ZH+EHxH2QQ5z/JZMFAglU6wJOpAIVK5GH1UnjLdrKWTogG6jIq Xh8QiEigHQtIktv+YOs6dEek7c6ToXEo3I88AnFopsVRVB0/RQLQtrj85WwR3VQl0ZYi hc4gtI4WdMyOu/l+NH1ny2rJb5C4O+9qrV53XCQFJXGPbtGk7o1Ydpj0fuuFZgG/CTk9 D3tQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a14si802189eds.487.2020.07.08.16.09.40; Wed, 08 Jul 2020 16:10:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726251AbgGHXJ2 (ORCPT + 99 others); Wed, 8 Jul 2020 19:09:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726065AbgGHXJ2 (ORCPT ); Wed, 8 Jul 2020 19:09:28 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E220BC061A0B; Wed, 8 Jul 2020 16:09:27 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 7E0FD12780FED; Wed, 8 Jul 2020 16:09:26 -0700 (PDT) Date: Wed, 08 Jul 2020 16:09:25 -0700 (PDT) Message-Id: <20200708.160925.601637997950999733.davem@davemloft.net> To: jarod@redhat.com Cc: linux-kernel@vger.kernel.org, syzbot+582c98032903dcc04816@syzkaller.appspotmail.com, huyn@mellanox.com, saeedm@mellanox.com, j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net, jeffrey.t.kirsher@intel.com, kuba@kernel.org, steffen.klassert@secunet.com, herbert@gondor.apana.org.au, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org Subject: Re: [PATCH net-next] bonding: don't need RTNL for ipsec helpers From: David Miller In-Reply-To: <20200708225849.25198-1-jarod@redhat.com> References: <20200708225849.25198-1-jarod@redhat.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 08 Jul 2020 16:09:27 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jarod Wilson Date: Wed, 8 Jul 2020 18:58:49 -0400 > The bond_ipsec_* helpers don't need RTNL, and can potentially get called > without it being held, so switch from rtnl_dereference() to > rcu_dereference() to access bond struct data. > > Lightly tested with xfrm bonding, no problems found, should address the > syzkaller bug referenced below. > > Reported-by: syzbot+582c98032903dcc04816@syzkaller.appspotmail.com > Signed-off-by: Jarod Wilson Applied, thank you.