Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [Proposal] DRM: AMD: Convert logging to drm_* functions.
To:     Suraj Upadhyay <usuraj35@gmail.com>, alexander.deucher@amd.com
Cc:     amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20200708161123.GA30962@blackclown>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <e5389684-424e-6a38-37d8-9910cdb8b2f3@amd.com>
Date:   Thu, 9 Jul 2020 09:14:15 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
In-Reply-To: <20200708161123.GA30962@blackclown>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7] (2a02:908:1252:fb60:be8a:bd56:1f94:86e7) by AM0P190CA0015.EURP190.PROD.OUTLOOK.COM (2603:10a6:208:190::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21 via Frontend Transport; Thu, 9 Jul 2020 07:14:19 +0000
X-Originating-IP: [2a02:908:1252:fb60:be8a:bd56:1f94:86e7]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 0fc1c0dc-345f-4738-179f-08d823d7b347
X-MS-TrafficTypeDiagnostic: MN2PR12MB4375:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MN2PR12MB437542EC31D537FE8300935A83640@MN2PR12MB4375.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: rObzAwXJYvw/f8+kT+BbDns/5wnNamYJpJpix6YxsP95KrlrxH8J4HeoPbA9CPyL3i5I2tx3/Dj92rOCPM/+jscSIaOeEuj5Mz8bcBAOkZfKGTWCasykJnitRtvIvxn69y9Zp7LpZJb4/4VSpoJZGyYwuCYoG3lzlPO6QUws1qV5HbdpS9wSwi2BNTws0S+YnoZrHrQGYPdkyKhQPFkOcB7hisjNgKHiAbvgYxwtdHEZBAXfY4DKhl+K4y/qzvtvWYl8cCMO0bzAocJC5DvPfpLq+2I6L7vTxVGQfl/exI/Rz8SVTzZLXeJ51l+vl563Gn9FOAmOM6DWjFJhAoZ18x6yFSbkGbRvoDSjz8lTMxSeWTPnFoLQrpdZef5WPc+1LCJdTRiIg476An/tLxZ+MH4hEH68gywRgBHQ6cG4WdI=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3775.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(396003)(39860400002)(136003)(366004)(376002)(5660300002)(4326008)(86362001)(52116002)(31686004)(2616005)(6486002)(6666004)(8676002)(478600001)(6636002)(66946007)(66476007)(66556008)(186003)(16526019)(966005)(8936002)(2906002)(31696002)(36756003)(316002)(83380400001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: hkE4Q73nKoYamwbV6zq6wWUTXGLjjjY5PeWWzpmqZk6bl78G43VYEo5z3CVUTbrhJ3Kug++D8YL0asNwQRm/E131b6dAUbUp7U3iemmwqUfjOoIWqify951XpuZy8kgycqSWvD7FZLXHJ7w4RVb9DoZmA7SE6MAQ1qokqADqt1XQw+AaUAbgD5YxQW4bCPTLXFT1O5MGtbilUOify1KxzQeUuzgk0xrlJGha+ETCPYk9g6U7i0fTflAIISj90NJfriXA2zsgDcYUxYomnoqjqe6cc/rGA1KBcDG3lU0PYtoL2KTSMuyIeZf70RiC6IPfMUH2Rss9gKUqY9hKZlgzS5l6vFDP7b0CrmDkIA/o6zWKbLdEzdSfjNehbww96eNfesgRCKbHa5UNi90vUZuH6f7pXJbn4b/mKI1cMapid+uPsnv+rYhrvvuhHQ8xMWE23uAJrOkDvbcrpfiQG1/WWkgb9ClYrcb8Y8bL/gO/SJh+SiQEuSFugPPygZMJg/zejrSfYZ+JJlAzBbdw8JnJAXASMcujhJyKILtovvhOE01sjgrloyrUplyO1r8uS7qN
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0fc1c0dc-345f-4738-179f-08d823d7b347
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3775.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jul 2020 07:14:20.7095
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Viuqak/Z/Nya7Lqsxu1Skw20pJ2+uooWlyop35BrsuH2U15TxorQ8zbCzAat///V
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4375
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 08.07.20 um 18:11 schrieb Suraj Upadhyay:
> Hii AMD Maintainers,
> 	I plan to convert logging of information, error and warnings
> inside the AMD driver(s) to drm_* functions and macros for loggin,
> as described by the TODO list in the DRM documentation[1].
>
> I need your approval for the change before sending any patches, to make
> sure that this is a good idea and that the patches will be merged.
>
> The patches will essentially convert all the dev_info(), dev_warn(),
> dev_err() and dev_err_once() to drm_info(), drm_warn(), drm_err() and
> drm_err_once() respectively.

Well to be honest I would rather like see the conversion done in the 
other direction.

I think the drm_* functions are just an unnecessary extra layer on top 
of the core kernel functions and should probably be removed sooner or 
later because of midlayering.

Regards,
Christian.

>
> Thank You,
>
> Suraj Upadhyay.
>
> [1] https://dri.freedesktop.org/docs/drm/gpu/todo.html#convert-logging-to-drm-functions-with-drm-device-paramater
>