Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200708202355.28507-1-digetx@gmail.com> <20200708202355.28507-4-digetx@gmail.com>
 <CAHp75VejftNuSqdYvd1YE1SdRON6=mQ_iD2dEr4K9D8YGgeRBQ@mail.gmail.com> <675c4691-d372-4fe1-d515-c86fdba2f588@gmail.com>
In-Reply-To: <675c4691-d372-4fe1-d515-c86fdba2f588@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 9 Jul 2020 12:07:44 +0300
Message-ID: <CAHp75Vd89QpwaGvkpzG+pxnLd8S2guPCARLW5xPwhxXL8ZRfFw@mail.gmail.com>
Subject: Re: [PATCH v3 3/6] gpio: max77620: Don't set of_node
To:     Dmitry Osipenko <digetx@gmail.com>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jul 9, 2020 at 12:44 AM Dmitry Osipenko <digetx@gmail.com> wrote:
> 08.07.2020 23:57, Andy Shevchenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> > On Wednesday, July 8, 2020, Dmitry Osipenko <digetx@gmail.com
> > <mailto:digetx@gmail.com>> wrote:

...

> > I gave a second look and I think my suggestion is wrong. Here is an
> > interesting propagation of the parent device node to its grand son,
> > leaving son=E2=80=99s one untouched. Original code has intentions to do=
 that way.
>
> The [1] says that gpio_chip.parent should point at the "device providing
> the GPIOs".

Yes, physical device I believe.

> That's the pdev->dev.parent in the case of this driver.
> MAX77620 is an MFD PMIC device that has virtual sub-devices like GPIO
> controller, PINCTRL and RTC. The MFD is the parent device that provides
> the GPIOs [2].
>
> [1]
> https://elixir.bootlin.com/linux/v5.8-rc3/source/include/linux/gpio/drive=
r.h#L276
>
> [2]
> https://elixir.bootlin.com/linux/v5.8-rc3/source/arch/arm64/boot/dts/nvid=
ia/tegra210-p2180.dtsi#L48
>
> I think the old code was wrong and this patch is correct, please correct
> me if I'm missing something.

Hmm... I have checked through GPIO drivers I have knowledge of / care
about and PMIC ones do like you suggested in this patch, the rest
(which are instantiated from MFD) take a virtual platform device.

Looking at DT excerpt I think you're rather right than wrong, so I
leave it to you and maintainers.
Thanks!

--=20
With Best Regards,
Andy Shevchenko