Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] scsi: fcoe: add missed kfree() in an error path
To:     Markus Elfring <Markus.Elfring@web.de>,
        <linux-scsi@vger.kernel.org>
References: <977e2781-99ed-54c0-27ad-82d768a1c1e6@web.de>
 <5F067CDA.8010404@huawei.com> <ec1e1405-7582-0709-f2a5-a8b91e45fa1a@web.de>
CC:     <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        "Hannes Reinecke" <hare@suse.de>,
        "James E. J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Neerav Parikh <Neerav.Parikh@intel.com>
From:   Jing Xiangfeng <jingxiangfeng@huawei.com>
Message-ID: <5F06FA99.7030705@huawei.com>
Date:   Thu, 9 Jul 2020 19:08:09 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <ec1e1405-7582-0709-f2a5-a8b91e45fa1a@web.de>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2020/7/9 15:22, Markus Elfring wrote:
>>>> fcoe_fdmi_info() misses to call kfree() in an error path.
>>>> Add the missed function call to fix it.
>>>
>>> I suggest to use an additional jump target for the completion
>>> of the desired exception handling.
>>>
>>>
>>> …
>>>> +++ b/drivers/scsi/fcoe/fcoe.c
>>>> @@ -830,6 +830,7 @@ static void fcoe_fdmi_info(struct fc_lport *lport, struct net_device *netdev)
>>>>            if (rc) {
>>>>                printk(KERN_INFO "fcoe: Failed to retrieve FDMI "
>>>>                        "information from netdev.\n");
>>>> +            kfree(fdmi);
>>>>                return;
>>>>            }
>>>
>>> -            return;
>>> +            goto free_fdmi;
>>>
>>>
>>> How do you think about to apply any further coding style adjustments?
>>
>> The local variable "fdmi" is invisible to the function.
>
> I have got understanding difficulties for this information.
> The function call “kfree(fdmi)” is already used at the end of this if branch.
> Thus I propose to add a label there.
>
> Do you notice any additional improvement possibilities for this software module?

Indeed, Will change in the next version.
Thanks for your review
>
> Regards,
> Markus
> .
>