Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 45nC6U7Bv7mJjVYTZWqGyWG55S2sfdSXKEcrPpoWLWF++DAuAmuc7F3bo9BMjq72Tw1aXQIta9
 /YoDptNR1RFQ==
IronPort-SDR: OWaLNeZBmurGE0tfls9Q2CUa/rhJAuCmUH8nFuOlGcWQl+Rl23mb1bdok7/IQ+rBvSwIphLnW6
 cN3S2miYfZjA==
Date:   Thu, 9 Jul 2020 14:09:14 +0300
From:   Andy Shevchenko <andriy.shevchenko@intel.com>
To:     Amireddy Mallikarjuna reddy <mallikarjunax.reddy@linux.intel.com>
Cc:     dmaengine@vger.kernel.org, vkoul@kernel.org,
        devicetree@vger.kernel.org, robh+dt@kernel.org,
        linux-kernel@vger.kernel.org, chuanhua.lei@linux.intel.com,
        cheol.yong.kim@intel.com, qi-ming.wu@intel.com,
        malliamireddy009@gmail.com
Subject: Re: [PATCH v4 2/2] Add Intel LGM soc DMA support.
Message-ID: <20200709110914.GW3703480@smile.fi.intel.com>
References: <cover.1594273437.git.mallikarjunax.reddy@linux.intel.com>
 <6be9b9cfbf6708fe371f280cb94cbdc9c04bdccb.1594273437.git.mallikarjunax.reddy@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6be9b9cfbf6708fe371f280cb94cbdc9c04bdccb.1594273437.git.mallikarjunax.reddy@linux.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jul 09, 2020 at 02:01:06PM +0800, Amireddy Mallikarjuna reddy wrote:
> Add DMA controller driver for Lightning Mountain(LGM) family of SoCs.
> 
> The main function of the DMA controller is the transfer of data from/to any
> DPlus compliant peripheral to/from the memory. A memory to memory copy
> capability can also be configured.
> 
> This ldma driver is used for configure the device and channnels for data
> and control paths.

> +#include "../virt-dma.h"

I didn't find any evidence this driver utilizes virt-dma API in full.
For example, there is a virt_dma_desc structure and descriptor management around it.
Why don't you use it?

-- 
With Best Regards,
Andy Shevchenko