Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: RiZqg/TZoIsx8K3kehihIpnYtvk2jFUwAmrLfVZixk6GKfbaVbQ8DHSG2ax1Pu97xKRdlrEasI
 fAw86KDxbugw==
IronPort-SDR: y4vJ4FSs9Z6jcJbUsoaKk2oiO26qlStbYq75/4DVBLgd7FD/0d0q/yAHnvQa53UgJnyEX3cm2y
 JZvKe7vq82Gw==
Message-ID: <491f994c6f87a542e49fe37c8a75ab46f1b3712b.camel@linux.intel.com>
Subject: Re: [PATCH 2/7] mailbox: keembay-scmi-mailbox: Add support for Keem
 Bay mailbox
From:   Daniele Alessandrelli <daniele.alessandrelli@linux.intel.com>
To:     Sudeep Holla <sudeep.holla@arm.com>, paul.j.murphy@linux.intel.com
Cc:     linux-arm-kernel@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
        Paul Murphy <paul.j.murphy@intel.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Dinh Nguyen <dinguyen@kernel.org>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Date:   Thu, 09 Jul 2020 13:23:56 +0100
In-Reply-To: <20200708203428.GB31671@bogus>
References: <20200616155613.121242-1-daniele.alessandrelli@linux.intel.com>
         <20200616155613.121242-3-daniele.alessandrelli@linux.intel.com>
         <20200708203428.GB31671@bogus>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.3 (3.36.3-1.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Sudeep,

Thanks for your review.

On Wed, 2020-07-08 at 21:34 +0100, Sudeep Holla wrote:
> On Tue, Jun 16, 2020 at 04:56:08PM +0100, Daniele Alessandrelli
> wrote:
> > From: Paul Murphy <paul.j.murphy@intel.com>
> > 
> > Keem Bay SoC has a ARM trusted firmware-based secure monitor which
> > acts
> > as the SCP for the purposes of power management over SCMI.
> > 
> > This driver implements the transport layer for SCMI to function.
> > 
> 
> Please use the smc transport support in
> driver/firmware/arm_scmi/smc.c
> for this. You don't need mailbox support for SMC/HVC. Basically you
> don't need this driver at all and you have everything you need to
> support
> what you want.
> 
> Let me know if you face issues.
> 

Sorry, we didn't know about the SMC transport support for SCMI. Looks
like it was added only recently, while our driver was already developed
and waiting to be upstreamed.

I agree that we can drop this driver and switch to the SMC transport as
you suggested, but I think we'll have to modify our bootloader SiP
service slightly. Paul, can you elaborate?

Regards,
Daniele