Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1594285927-1840-1-git-send-email-neal.liu@mediatek.com> <1594285927-1840-3-git-send-email-neal.liu@mediatek.com>
In-Reply-To: <1594285927-1840-3-git-send-email-neal.liu@mediatek.com>
From:   Chun-Kuang Hu <chunkuang.hu@kernel.org>
Date:   Thu, 9 Jul 2020 21:01:44 +0800
Message-ID: <CAAOTY_-7PwoPG_0ce2p4BCNQ3rundg40Bsni14XSmVETExkKkw@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] soc: mediatek: add mtk-devapc driver
To:     Neal Liu <neal.liu@mediatek.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        devicetree@vger.kernel.org,
        wsd_upstream <wsd_upstream@mediatek.com>,
        lkml <linux-kernel@vger.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi, Neal:

Neal Liu <neal.liu@mediatek.com> =E6=96=BC 2020=E5=B9=B47=E6=9C=889=E6=97=
=A5 =E9=80=B1=E5=9B=9B =E4=B8=8B=E5=8D=885:13=E5=AF=AB=E9=81=93=EF=BC=9A
>
> MediaTek bus fabric provides TrustZone security support and data
> protection to prevent slaves from being accessed by unexpected
> masters.
> The security violation is logged and sent to the processor for
> further analysis or countermeasures.
>
> Any occurrence of security violation would raise an interrupt, and
> it will be handled by mtk-devapc driver. The violation
> information is printed in order to find the murderer.
>
> Signed-off-by: Neal Liu <neal.liu@mediatek.com>

[snip]

> +
> +static u32 get_shift_group(struct mtk_devapc_context *devapc_ctx,
> +                          int slave_type, int vio_idx)

vio_idx  is useless, so remove it.

> +{
> +       u32 vio_shift_sta;
> +       void __iomem *reg;
> +       int bit;
> +
> +       reg =3D mtk_devapc_pd_get(devapc_ctx, slave_type, VIO_SHIFT_STA, =
0);
> +       vio_shift_sta =3D readl(reg);
> +
> +       for (bit =3D 0; bit < 32; bit++) {
> +               if ((vio_shift_sta >> bit) & 0x1)
> +                       break;
> +       }
> +
> +       return bit;
> +}
> +

[snip]

> +
> +/*
> + * devapc_violation_irq - the devapc Interrupt Service Routine (ISR) wil=
l dump
> + *                       violation information including which master vi=
olates
> + *                       access slave.
> + */
> +static irqreturn_t devapc_violation_irq(int irq_number,
> +                                       struct mtk_devapc_context *devapc=
_ctx)
> +{
> +       const struct mtk_device_info **device_info;
> +       int slave_type_num;
> +       int vio_idx =3D -1;
> +       int slave_type;
> +
> +       slave_type_num =3D devapc_ctx->slave_type_num;
> +       device_info =3D devapc_ctx->device_info;
> +
> +       for (slave_type =3D 0; slave_type < slave_type_num; slave_type++)=
 {

If slave_type_num is 1, I think the code should be simpler.

> +               if (!mtk_devapc_dump_vio_dbg(devapc_ctx, slave_type, &vio=
_idx))
> +                       continue;
> +
> +               /* Ensure that violation info are written before
> +                * further operations
> +                */
> +               smp_mb();
> +
> +               mask_module_irq(devapc_ctx, slave_type, vio_idx, true);

Why do you mask irq?

> +
> +               clear_vio_status(devapc_ctx, slave_type, vio_idx);
> +
> +               mask_module_irq(devapc_ctx, slave_type, vio_idx, false);
> +       }
> +
> +       return IRQ_HANDLED;
> +}
> +
> +/*
> + * start_devapc - initialize devapc status and start receiving interrupt
> + *               while devapc violation is triggered.
> + */

[snip]

> +
> +struct mtk_device_info {
> +       int sys_index;

Useless, so remove it.

> +       int ctrl_index;

Ditto.

Regards,
Chun-Kuang.

> +       int vio_index;
> +};
> +