Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: k9RpCPMVYpOyPf5yfgokqH/ZHqXV9LTovVgr17raHSiZP4mD+VGsJVGvlATqbnf35G8aEEriCw
 Ek15ZpJqNCfg==
Message-Id: <537a4c$cobr4j@orsmga004-auth.jf.intel.com>
IronPort-SDR: lbGftqsvxRyXOACOGBHSm1In1Skp/KaIfrSFiKY6OurNhCBCCg5UvS81aWet1lIxbq8nWff6dl
 iJLteg35tBRA==
Subject: Re: [PATCH 2/7] mailbox: keembay-scmi-mailbox: Add support for Keem
 Bay mailbox
To:     Daniele Alessandrelli <daniele.alessandrelli@linux.intel.com>,
        Sudeep Holla <sudeep.holla@arm.com>
Cc:     linux-arm-kernel@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
        Paul Murphy <paul.j.murphy@intel.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Dinh Nguyen <dinguyen@kernel.org>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
References: <20200616155613.121242-1-daniele.alessandrelli@linux.intel.com>
 <20200616155613.121242-3-daniele.alessandrelli@linux.intel.com>
 <20200708203428.GB31671@bogus>
 <491f994c6f87a542e49fe37c8a75ab46f1b3712b.camel@linux.intel.com>
From:   Paul Murphy <paul.j.murphy@linux.intel.com>
Date:   Thu, 9 Jul 2020 14:28:10 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <491f994c6f87a542e49fe37c8a75ab46f1b3712b.camel@linux.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 7/9/20 13:23, Daniele Alessandrelli wrote:
> Hi Sudeep,
>
> Thanks for your review.
>
> On Wed, 2020-07-08 at 21:34 +0100, Sudeep Holla wrote:
>> On Tue, Jun 16, 2020 at 04:56:08PM +0100, Daniele Alessandrelli
>> wrote:
>>> From: Paul Murphy <paul.j.murphy@intel.com>
>>>
>>> Keem Bay SoC has a ARM trusted firmware-based secure monitor which
>>> acts
>>> as the SCP for the purposes of power management over SCMI.
>>>
>>> This driver implements the transport layer for SCMI to function.
>>>
>> Please use the smc transport support in
>> driver/firmware/arm_scmi/smc.c
>> for this. You don't need mailbox support for SMC/HVC. Basically you
>> don't need this driver at all and you have everything you need to
>> support
>> what you want.
>>
>> Let me know if you face issues.
>>
> Sorry, we didn't know about the SMC transport support for SCMI. Looks
> like it was added only recently, while our driver was already developed
> and waiting to be upstreamed.
>
> I agree that we can drop this driver and switch to the SMC transport as
> you suggested, but I think we'll have to modify our bootloader SiP
> service slightly. Paul, can you elaborate?
>

Just one question.

In our patch, we pass the shared memory address as the second argument 
of the SiP service, as it means we don't have to hardcode that in our 
firmware. Sudeep, do you know if it was intentional in 
smc_send_message() to leave that out? If we leave it out, we are 
requiring the secure monitor to hardcode the shared memory address.


Regards,
Paul