Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1466395ybt; Thu, 9 Jul 2020 07:44:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJznA/yCJNX44LZQnXkq4870I535MMYc6zPWutBI2lt73SdnwM42dyp274eERdPzqQ9AlWzK X-Received: by 2002:a05:6402:203a:: with SMTP id ay26mr59922402edb.276.1594305884912; Thu, 09 Jul 2020 07:44:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594305884; cv=none; d=google.com; s=arc-20160816; b=ACroUqbD2P6lcQsE0HBtaZAkFhcK9yPLDJdS1IyiVdlsUsGtU/n5xtUXysh4Au/kj9 /5GKflCXqbgzvK3CQq17+56OJDK60i20YRiZ/HpaL+z5EIfpX17PRwHv6yewMeELY8jN gQmu1zwH6K66U15xui2V2/T53pOo2/XvKpmKYfbrzbSnAyx1MXt/ekbTeG5PpfHE9V0i Ql8DKl2NI5vEooxP5sopiw2zN5H62jTzX/VFwbc/QSznDU7jjjGQh9uBmo4SFaCrBhlw 70yNH123XOPBIorou8jRAxeJ9S21p0rYWTqFq69JFKr9NjIDsbswicjUh41xCR05ttzj l4qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:references :in-reply-to:subject:cc:to:from:date:content-transfer-encoding :mime-version:dkim-signature; bh=3We4BhHnsmyDDmm6gtgYzv/izpXX1ppdDtsySi/iWzs=; b=1GmWUynwRYvq97zyZoTZULxm01CkENUYX/+5T9sjT6wrlAS/b0aeaHRw0DPOFgmjHW XawelfeAk/HFcsaGCax5idWsZ3oKy8tY0Og1hPqwsWFdFdxhNvwcByqbegIXithmzHNX BKkoZWf0T1Sdz+YkmydTqmgBQVl/dkTl0xxhtJr05jrLt7NvKfOLZ5ppVWVmx0QW9k9Y O7IUEdnNVBC0Zze35DzjRVmfjKiWXkeAIZ+NsrNrijCaKNgYm90/0Un6AAknfcsvCPF9 H3hjK1X3jKoXX/ZfXxY70gyy3ggLVR7cUagUbiD8SIxK6U89Kn2E7amO1+gSJCo6mcM8 A4tg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=t8FTN88F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i25si1996891ejy.603.2020.07.09.07.44.20; Thu, 09 Jul 2020 07:44:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=t8FTN88F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726847AbgGIOoF (ORCPT + 99 others); Thu, 9 Jul 2020 10:44:05 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:31775 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726353AbgGIOoF (ORCPT ); Thu, 9 Jul 2020 10:44:05 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1594305844; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=3We4BhHnsmyDDmm6gtgYzv/izpXX1ppdDtsySi/iWzs=; b=t8FTN88FNK+i9GbYLS2ecAMUUP2HeaCrYoLcBM4IXpMlS+J33t8RtVK61TLe1yXsame3XEdG gt+lvluu9fkXjiiKIuPxdenKxwy1WRtmoiRhLLI90sD1EQeSxurpCN5hWuJKbT7tKilHYPVU 4JNl9vfWhvJRGhKTmFGgioDARfw= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n14.prod.us-east-1.postgun.com with SMTP id 5f072d269f03943e5ce0ee16 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 09 Jul 2020 14:43:50 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 34F4DC43395; Thu, 9 Jul 2020 14:43:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: sibis) by smtp.codeaurora.org (Postfix) with ESMTPSA id 82D43C433C6; Thu, 9 Jul 2020 14:43:49 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Thu, 09 Jul 2020 20:13:49 +0530 From: Sibi Sankar To: Bjorn Andersson Cc: Steev Klimaszewski , viresh.kumar@linaro.org, sboyd@kernel.org, georgi.djakov@linaro.org, agross@kernel.org, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, saravanak@google.com, dianders@chromium.org, vincent.guittot@linaro.org, amit.kucheria@linaro.org, robdclark@chromium.org, linux-kernel-owner@vger.kernel.org Subject: Re: [PATCH v2] arm64: dts: qcom: sdm845: Add cpu OPP tables In-Reply-To: <20200709142918.GA3521288@ripper> References: <20200702204643.25785-1-sibis@codeaurora.org> <20200709142918.GA3521288@ripper> Message-ID: X-Sender: sibis@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-07-09 19:59, Bjorn Andersson wrote: > On Wed 08 Jul 19:22 PDT 2020, Steev Klimaszewski wrote: > >> >> On 7/2/20 3:46 PM, Sibi Sankar wrote: >> > Add OPP tables required to scale DDR/L3 per freq-domain on SDM845 SoCs. >> > >> > Signed-off-by: Sibi Sankar >> > --- >> >> >> Hi Sibi, >> >> >> Bjorn asked me to give this patch a whirl, and I have to say, I like >> it >> but I'm not sure if I'm missing a dependency somewhere... >> >> >> In 5.8.0-rc4, I'm seeing a couple probe defers >> >> [    0.131341] cpu cpu0: _allocate_opp_table: Error finding >> interconnect >> paths: -517 >> >> [    0.132694] cpu cpu4: _allocate_opp_table: Error finding >> interconnect >> paths: -517 >> >> And then a bit later on, >> >> [    0.625837] cpu cpu0: failed to get clock: -2 >> >> >> If these aren't anything to worry about, you can throw my Tested-by on >> >> Tested-by: Steev Klimaszewski >> > > You need to enable: > CONFIG_INTERCONNECT=y > CONFIG_INTERCONNECT_QCOM=y > CONFIG_INTERCONNECT_QCOM_OSM_L3=m > CONFIG_INTERCONNECT_QCOM_SDM845=m Steev had ^^ enabled but he was missing the required cpufreq driver changes available in linux-next. > > With this I can see the interconnect_summary in debugfs change with the > CPU frequency. > > Regards, > Bjorn -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.