Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1475786ybt; Thu, 9 Jul 2020 07:58:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwk6zbsTF0PNWl4MkQglUEcELzu9ZOtxiPGFdBMFvnKzvEIEqJ06DkQGyqzt2IXRWUAbWAu X-Received: by 2002:a17:906:3e13:: with SMTP id k19mr55615982eji.476.1594306708389; Thu, 09 Jul 2020 07:58:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594306708; cv=none; d=google.com; s=arc-20160816; b=0z0HSnWch6Jt6XRmMDCuKBRI2mFVP+ueTaLJwuSwLo+LQVZx+w3rLd/7ekSgTTfmmi FYFqPCJQtmrfZvf+Rzo7sGY4IlQxM8lqJ4tAczq5omVA36UxTLR2cNXIQQh8JxMtoNkR ifllMdz+SxAM9yNb9qkhap/54oztBIbPWculUQ0g0L7YU0jPpDc0RR2ngQHoRHRv56k5 QKX2KuFAZ51ffP3DSxB8/5CRHIaoPD7nZsBOaV7IUkTRQBUnsY0dGqge7M084k8yAXCS QxT1cOTswdr+bsrAQq5ODj4dLfQAMf+sH858YVRja0JPe5zKBa82iGwanNoKeifNI3bj 7uVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:cc :references:to:subject; bh=fpFkTV2lUtk91L2bYAU77/7Lg3zTXgUb3k+Hg51MCfQ=; b=sHw5p9y1Xzg6CIlLSeC/mxGpjVOvuXf4vcDzBc3olktAF3cJvhoBkKJ9s6tFYwatSt WVAwRBPcL7iOro8Heg7PCwPeI8Oioqoyg9sFSDMIZdsujNI14UrQOTY+x5th+k+qUYG+ ZmFPECRxhQa9uJC8BX/snt4orRpQCQ1mwU2tYMZNgYN1Ju9Nks4vxXiUcIsX5KhCK8aB jXPXbgV70AJcL9aNYtsjAy+Auep+aQH/s8uPdUR11w7TovhPt02OAKNilIUI1RH6htKH cMKzU5vVg0I6pVtcenjYxISEk/3DN3y9Nbp8d1DMp24WIQtu/aU5+aIF3xklSqzmFd/v a/Lw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=qQqVLN9w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t28si2160193edc.97.2020.07.09.07.58.05; Thu, 09 Jul 2020 07:58:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=qQqVLN9w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728103AbgGIO5k (ORCPT + 99 others); Thu, 9 Jul 2020 10:57:40 -0400 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:16147 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727092AbgGIO5k (ORCPT ); Thu, 9 Jul 2020 10:57:40 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 09 Jul 2020 07:56:45 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 09 Jul 2020 07:57:39 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 09 Jul 2020 07:57:39 -0700 Received: from [10.19.64.157] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 9 Jul 2020 14:57:36 +0000 Subject: Re: [PATCH v3 2/6] gpio: max77620: Fix missing release of interrupt To: Dmitry Osipenko , Thierry Reding , Jonathan Hunter , "Bartosz Golaszewski" , Linus Walleij , Andy Shevchenko References: <20200708202355.28507-1-digetx@gmail.com> <20200708202355.28507-3-digetx@gmail.com> CC: , , From: Laxman Dewangan Message-ID: <80f4d1ff-8096-9060-3cf0-a59448866c40@nvidia.com> Date: Thu, 9 Jul 2020 20:27:04 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20200708202355.28507-3-digetx@gmail.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1594306605; bh=fpFkTV2lUtk91L2bYAU77/7Lg3zTXgUb3k+Hg51MCfQ=; h=X-PGP-Universal:Subject:To:References:CC:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding; b=qQqVLN9wngC//dx2qrXZv//b39BIvaw9zxCJ7yy6+tzGbz/dROUqIQwqz4hjO4JcJ 5dBOvT9bW3xx7MbdMprwQfCBQZDEQOcbtq/376FU7W1LP3plg910I5lVBZlKp7FQB1 QxQgPxgNvLmbOeOi6nmdxhcr6HtCZn5QjAzPbDqhwd+PHTTewWJJBx0RvAG635GizN xdKZdl5681cPtjx+HEWyygzxWkFOQlaw9y1Fxi24Sq/NNRt9CPesIHzsXepcbRGTfh bMj8fkrXTu0fX81F1K9ac5/dOjzJByHcd7M8+s2KxA1WoyVadTKeNh3SlXRjL721ZQ IME8S/dTBnpBg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 09 July 2020 01:53 AM, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > The requested interrupt is never released by the driver. Fix this by > using the resource-managed variant of request_threaded_irq(). > > Fixes: ab3dd9cc24d4 ("gpio: max77620: Fix interrupt handling") > Signed-off-by: Dmitry Osipenko Looks good to me. Acked-by: Laxman Dewangan